[jira] [Commented] (LANG-1681) Wrong javadoc exception in several methods and classes

["Bruno P. Kinoshita (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707855#comment-17707855 ] 

Bruno P. Kinoshita commented on LANG-1681:
------------------------------------------

Hi [~dvmarcilio] ,

 

Please have a look at the linked pull request 1047. It is related to this issue, but only fixes a handful of these methods that throw NPE. You mentioned that your tool found 85 methods. It would be interesting if you could comment here or in that pull request pointing to other methods that need to be updated as well.

Thanks

Bruno

> Wrong javadoc exception in several methods and classes 
> -------------------------------------------------------
>
>                 Key: LANG-1681
>                 URL: https://issues.apache.org/jira/browse/LANG-1681
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*, lang.builder.*, lang.math.*, lang.reflect.*, lang.time.*
>    Affects Versions: 3.12.0
>            Reporter: Diego Marcilio
>            Priority: Minor
>
> I'm working on a tool that can systematically extract some exceptions thrown by methods. It found 85 methods that throw {{NullPointerException}} 's but with a javadoc documenting an {{{}IllegalArgumentException{}}}.
> I believe these inconsistencies were caused by LANG-1525, where several {{{}Validate.isTrue({}}}) (throws IAE) calls were changed to {{{}Validate.notNull(){}}}, which calls {{Objects.requireNonNull()}} (throws NPE). The tests were updated, but not the documentation.
> LANG-1663 already fixed a few inconsistent javadocs, but there are dozens left.
>  
> May I provide a pull request fixing the cases I found? Should a single PR contain all the changes?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)