You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2007/10/27 22:59:18 UTC

[PATCH] Respect --without-sqlite option when SQLite is installed

`./configure --without-sqlite` doesn't disable using of SQLite when SQLite
is installed. It's wrong behavior [1].

I'm attaching a patch which fixes this bug.

[[[
Respect --without-sqlite option when SQLite is installed.

* build/ac-macros/sqlite.m4
  (SVN_LIB_SQLITE): Respect --without-sqlite option.

Patch by: arfrever
]]]

[1] http://www.gentoo.org/proj/en/qa/automagic.xml

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] Respect --without-sqlite option when SQLite is installed

Posted by "Daniel L. Rall" <dl...@collab.net>.
On Sun, 28 Oct 2007, Arfrever Frehtes Taifersar Arahesis wrote:

> 2007-10-28 15:37:13 Mark Phippard napisał(a):
> > On 10/27/07, Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> wrote:
> > > `./configure --without-sqlite` doesn't disable using of SQLite when SQLite
> > > is installed. It's wrong behavior [1].
> > >
> > > I'm attaching a patch which fixes this bug.
> > 
> > I thought we had decided that we did not want to support doing a build
> > without SQLite. That would basically mean having a build that does not
> > support ra_local at all.
> > 
> 
> OK. So please update INSTALL.
> Now it claims:
>       * SQLite (REQUIRED for server)
> 
>          SQLite is a lightweight, embeddable SQL library.  The
>          Subversion repository uses a SQLite database to track merge
>          data.  If SQLite is not found at compile time, then no server
>          binaries or libraries will be built -- you'll only get a
>          client.

Thanks Arfrever, fixed in r27459.
-- 

Daniel Rall

Re: [PATCH] Respect --without-sqlite option when SQLite is installed

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2007-10-28 15:37:13 Mark Phippard napisał(a):
> On 10/27/07, Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> wrote:
> > `./configure --without-sqlite` doesn't disable using of SQLite when SQLite
> > is installed. It's wrong behavior [1].
> >
> > I'm attaching a patch which fixes this bug.
> 
> I thought we had decided that we did not want to support doing a build
> without SQLite. That would basically mean having a build that does not
> support ra_local at all.
> 

OK. So please update INSTALL.
Now it claims:
      * SQLite (REQUIRED for server)

         SQLite is a lightweight, embeddable SQL library.  The
         Subversion repository uses a SQLite database to track merge
         data.  If SQLite is not found at compile time, then no server
         binaries or libraries will be built -- you'll only get a
         client.


-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] Respect --without-sqlite option when SQLite is installed

Posted by Mark Phippard <ma...@gmail.com>.
On 10/27/07, Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> wrote:
> `./configure --without-sqlite` doesn't disable using of SQLite when SQLite
> is installed. It's wrong behavior [1].
>
> I'm attaching a patch which fixes this bug.

I thought we had decided that we did not want to support doing a build
without SQLite. That would basically mean having a build that does not
support ra_local at all.

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Respect --without-sqlite option when SQLite is installed

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2007-10-28 00:58:55 Arfrever Frehtes Taifersar Arahesis napisał(a):
> `./configure --without-sqlite` doesn't disable using of SQLite when SQLite
> is installed. It's wrong behavior [1].
> 
> I'm attaching a patch which fixes this bug.
> 
> [[[
> Respect --without-sqlite option when SQLite is installed.
> 
> * build/ac-macros/sqlite.m4
>   (SVN_LIB_SQLITE): Respect --without-sqlite option.
> 
> Patch by: arfrever
> ]]]
> 
> [1] http://www.gentoo.org/proj/en/qa/automagic.xml
> 

Please ignore it.
I sent it accidentally.
Not ready yet.

-- 
Arfrever Frehtes Taifersar Arahesis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org