[GitHub] wujimin commented on a change in pull request #944: [SCB-950] modify consumer producer metrics and add edge metrics

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #944: [SCB-950] modify consumer producer metrics and add edge metrics
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#discussion_r223216687
 
 

 ##########
 File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/statistics/MeterDetailStatisticsModel.java
 ##########
 @@ -0,0 +1,204 @@
+package org.apache.servicecomb.metrics.core.publish.statistics;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.servicecomb.metrics.core.meter.invocation.MeterInvocationConst;
+import org.apache.servicecomb.metrics.core.publish.model.invocation.OperationPerf;
+import org.apache.servicecomb.metrics.core.publish.model.invocation.PerfInfo;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class MeterDetailStatisticsModel {
 
 Review comment:
   why need this model?
   
   enum the stages, just like the old logic, seems simpler?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services