You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by gi...@git.apache.org on 2017/06/29 13:54:32 UTC

[GitHub] eolivelli commented on issue #217: Code cleanups

eolivelli commented on issue #217: Code cleanups
URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-311973591
 
 
   Thank you @sigee interesting proposal.
   
   @sijie I think this patch could break some pending Pull Request
   
   in general I am OK with this kind of patch but I think it would be better to have such cleanup at the start of next release or at the end of 4.5
   
   it would be great to add maven checkstyle plugin to in the build pipeline in order to guarantee our coding conventions
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services