[GitHub] [beam] lostluck commented on a diff in pull request #26101: [WIP] Timers with new datalayer

["lostluck (via GitHub)" <gi...@apache.org>]

lostluck commented on code in PR #26101:
URL: https://github.com/apache/beam/pull/26101#discussion_r1157507572


##########
sdks/go/pkg/beam/core/graph/fn.go:
##########
@@ -304,6 +308,40 @@ func (f *DoFn) PipelineState() []state.PipelineState {
 	return s
 }
 
+type PipelineTimer interface {
+	TimerFamily() string
+	TimerDomain() timers.TimeDomainEnum
+}

Review Comment:
   What do you think about switching this to  just a "Timers() map[string]timer.Domain" method, to enable the composites I proposed? https://github.com/apache/beam/issues/25894
   
   We wouldn't need to make the State change in this PR (way way out of scope), but now is ideal for enabling this for timers.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org