You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "David M. Sledge (JIRA)" <ji...@apache.org> on 2010/03/04 23:07:27 UTC

[jira] Created: (LANG-599) ClassUtils.getClass(): Allow Dots as Inner Class Separators

ClassUtils.getClass():  Allow Dots as Inner Class Separators
------------------------------------------------------------

                 Key: LANG-599
                 URL: https://issues.apache.org/jira/browse/LANG-599
             Project: Commons Lang
          Issue Type: Improvement
          Components: lang.reflect.*
            Reporter: David M. Sledge
            Priority: Trivial
         Attachments: ClassUtils-Inner-Class-Dot-Separator.patch

For convenience, I'd like to reference FQCNs consisistently between source code, string literals, properties files, and configuration files in general.  To that end I'm recommending a patch for {{ClassUtils.getClass()}} that allows dots (.) as inner class separators as well as the standard dollar sign ($).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-599) ClassUtils.getClass(): Allow Dots as Inner Class Separators

Posted by "David M. Sledge (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841649#action_12841649 ] 

David M. Sledge commented on LANG-599:
--------------------------------------

And "{{[Lpackage.of.SomeClass;}}" is the official JVM syntax for an array class of non-primitives.  I'm thankful that ClassUtils understands the syntax "{{package.of.SomeClass[]}}" just as readily.

> ClassUtils.getClass():  Allow Dots as Inner Class Separators
> ------------------------------------------------------------
>
>                 Key: LANG-599
>                 URL: https://issues.apache.org/jira/browse/LANG-599
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: David M. Sledge
>            Priority: Trivial
>         Attachments: ClassUtils-Inner-Class-Dot-Separator.patch
>
>
> For convenience, I'd like to reference FQCNs consisistently between source code, string literals, properties files, and configuration files in general.  To that end I'm recommending a patch for {{ClassUtils.getClass()}} that allows dots (.) as inner class separators as well as the standard dollar sign ($).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (LANG-599) ClassUtils.getClass(): Allow Dots as Inner Class Separators

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-599.
------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0

Looks good - patch applied. Thanks David.

svn ci -m "Per David M. Sledge's patch to LANG-599, added support to ClassUtils.getClass(String) to support inner classes being separated by '.' as well as the official '$'" src/
Sending        src/main/java/org/apache/commons/lang3/ClassUtils.java
Sending        src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
Transmitting file data ..
Committed revision 919340.


> ClassUtils.getClass():  Allow Dots as Inner Class Separators
> ------------------------------------------------------------
>
>                 Key: LANG-599
>                 URL: https://issues.apache.org/jira/browse/LANG-599
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: David M. Sledge
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: ClassUtils-Inner-Class-Dot-Separator.patch
>
>
> For convenience, I'd like to reference FQCNs consisistently between source code, string literals, properties files, and configuration files in general.  To that end I'm recommending a patch for {{ClassUtils.getClass()}} that allows dots (.) as inner class separators as well as the standard dollar sign ($).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-599) ClassUtils.getClass(): Allow Dots as Inner Class Separators

Posted by "David M. Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David M. Sledge updated LANG-599:
---------------------------------

    Attachment: ClassUtils-Inner-Class-Dot-Separator.patch

> ClassUtils.getClass():  Allow Dots as Inner Class Separators
> ------------------------------------------------------------
>
>                 Key: LANG-599
>                 URL: https://issues.apache.org/jira/browse/LANG-599
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: David M. Sledge
>            Priority: Trivial
>         Attachments: ClassUtils-Inner-Class-Dot-Separator.patch
>
>
> For convenience, I'd like to reference FQCNs consisistently between source code, string literals, properties files, and configuration files in general.  To that end I'm recommending a patch for {{ClassUtils.getClass()}} that allows dots (.) as inner class separators as well as the standard dollar sign ($).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-599) ClassUtils.getClass(): Allow Dots as Inner Class Separators

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841616#action_12841616 ] 

Paul Benedict commented on LANG-599:
------------------------------------

It's an interesting patch, but $ is the official JVM separator of an inner class. OTOH, if I do a "Copy Qualified Name" in Eclipse, it uses all dots.

> ClassUtils.getClass():  Allow Dots as Inner Class Separators
> ------------------------------------------------------------
>
>                 Key: LANG-599
>                 URL: https://issues.apache.org/jira/browse/LANG-599
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: David M. Sledge
>            Priority: Trivial
>         Attachments: ClassUtils-Inner-Class-Dot-Separator.patch
>
>
> For convenience, I'd like to reference FQCNs consisistently between source code, string literals, properties files, and configuration files in general.  To that end I'm recommending a patch for {{ClassUtils.getClass()}} that allows dots (.) as inner class separators as well as the standard dollar sign ($).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.