You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/02/19 08:31:21 UTC
[PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Gabriel39 opened a new pull request, #31109:
URL: https://github.com/apache/doris/pull/31109
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1951998505
TeamCity be ut coverage result:
Function Coverage: 35.78% (8558/23917)
Line Coverage: 27.72% (69390/250300)
Region Coverage: 26.85% (36018/134150)
Branch Coverage: 23.65% (18421/77876)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7d1e196cc377b2436160d1c3678008628b461757_7d1e196cc377b2436160d1c3678008628b461757/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952516245
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit ca6b4d025c0d31f2d8a0edfd106c988102bf4277 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 14.3 seconds inserted 10000000 Rows, about 699K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952510559
<details>
<summary>ClickBench: <b>Total hot run time: 30.35 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ca6b4d025c0d31f2d8a0edfd106c988102bf4277, data reload: false
query1 0.03 0.02 0.03
query2 0.06 0.03 0.03
query3 0.23 0.07 0.07
query4 1.66 0.08 0.08
query5 0.48 0.48 0.48
query6 1.37 0.59 0.61
query7 0.01 0.01 0.01
query8 0.04 0.03 0.03
query9 0.52 0.45 0.45
query10 0.50 0.49 0.49
query11 0.12 0.10 0.10
query12 0.13 0.10 0.10
query13 0.59 0.59 0.58
query14 0.78 0.78 0.80
query15 0.82 0.81 0.79
query16 0.32 0.32 0.35
query17 0.89 0.94 0.89
query18 0.19 0.17 0.16
query19 1.79 1.70 1.68
query20 0.01 0.00 0.01
query21 15.40 0.64 0.57
query22 2.79 4.49 2.06
query23 17.48 1.04 0.97
query24 2.01 0.75 0.21
query25 0.58 0.07 0.07
query26 0.17 0.15 0.14
query27 0.05 0.06 0.05
query28 11.98 0.82 0.82
query29 12.59 3.28 3.22
query30 0.52 0.49 0.50
query31 2.78 0.36 0.37
query32 3.33 0.47 0.47
query33 3.13 3.14 3.08
query34 15.33 4.52 4.50
query35 4.53 4.51 4.46
query36 1.06 0.95 0.95
query37 0.07 0.05 0.06
query38 0.05 0.03 0.03
query39 0.02 0.02 0.02
query40 0.17 0.15 0.14
query41 0.07 0.01 0.01
query42 0.03 0.02 0.01
query43 0.02 0.02 0.02
Total cold run time: 104.7 s
Total hot run time: 30.35 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1951955766
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952422671
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952480547
<details>
<summary>TPC-H: <b>Total hot run time: 41886 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ca6b4d025c0d31f2d8a0edfd106c988102bf4277, data reload: false
------ Round 1 ----------------------------------
q1 19478 5248 5159 5159
q2 2395 145 137 137
q3 11887 1045 1046 1045
q4 5046 1018 1012 1012
q5 7818 3171 3305 3171
q6 196 138 131 131
q7 1269 810 777 777
q8 9380 2112 2093 2093
q9 8136 6716 6709 6709
q10 8324 2670 2639 2639
q11 416 206 212 206
q12 762 333 333 333
q13 18004 3698 3683 3683
q14 289 265 258 258
q15 601 508 506 506
q16 483 413 416 413
q17 955 859 870 859
q18 7381 6734 6595 6595
q19 1534 1513 1496 1496
q20 641 345 333 333
q21 6073 4004 3997 3997
q22 879 346 334 334
Total cold run time: 111947 ms
Total hot run time: 41886 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4864 4842 4831 4831
q2 296 186 183 183
q3 3619 3590 3622 3590
q4 2517 2543 2531 2531
q5 5773 5776 5768 5768
q6 213 126 124 124
q7 2227 1660 1654 1654
q8 3050 3112 3121 3112
q9 8754 8747 8713 8713
q10 6893 4256 4254 4254
q11 513 355 370 355
q12 769 538 537 537
q13 4207 3414 3376 3376
q14 272 227 251 227
q15 595 508 503 503
q16 477 438 437 437
q17 1707 1634 1633 1633
q18 8396 7661 7530 7530
q19 1644 1641 1655 1641
q20 2105 1845 1823 1823
q21 6638 6169 6179 6169
q22 603 507 510 507
Total cold run time: 66132 ms
Total hot run time: 59498 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1951938145
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952482117
TeamCity be ut coverage result:
Function Coverage: 35.77% (8558/23925)
Line Coverage: 27.72% (69397/250361)
Region Coverage: 26.85% (36021/134179)
Branch Coverage: 23.65% (18420/77882)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca6b4d025c0d31f2d8a0edfd106c988102bf4277_ca6b4d025c0d31f2d8a0edfd106c988102bf4277/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952500878
<details>
<summary>TPC-DS: <b>Total hot run time: 186248 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ca6b4d025c0d31f2d8a0edfd106c988102bf4277, data reload: false
query1 914 353 346 346
query2 6513 1811 1803 1803
query3 6728 201 201 201
query4 23074 21150 21133 21133
query5 4216 456 451 451
query6 257 164 164 164
query7 4603 309 293 293
query8 249 189 210 189
query9 8459 2796 2767 2767
query10 404 213 221 213
query11 15081 14550 14404 14404
query12 139 84 82 82
query13 1693 429 410 410
query14 9069 7576 7653 7576
query15 214 184 196 184
query16 7549 255 255 255
query17 1410 553 533 533
query18 1972 274 259 259
query19 195 144 147 144
query20 87 81 87 81
query21 193 121 122 121
query22 5127 5051 5106 5051
query23 32526 31454 31532 31454
query24 12686 3448 3418 3418
query25 642 366 367 366
query26 1856 148 159 148
query27 3075 318 299 299
query28 6631 1836 1827 1827
query29 1125 605 607 605
query30 285 140 147 140
query31 930 749 755 749
query32 95 58 58 58
query33 707 237 244 237
query34 1067 474 497 474
query35 927 817 817 817
query36 1004 849 884 849
query37 157 61 65 61
query38 3325 3183 3192 3183
query39 1365 1345 1306 1306
query40 284 106 107 106
query41 37 34 35 34
query42 103 96 96 96
query43 477 452 460 452
query44 1062 679 690 679
query45 196 191 172 172
query46 1051 776 759 759
query47 1678 1561 1554 1554
query48 416 342 334 334
query49 1270 304 305 304
query50 769 377 367 367
query51 5338 5195 5246 5195
query52 102 94 89 89
query53 399 295 295 295
query54 285 218 229 218
query55 84 79 76 76
query56 217 194 205 194
query57 1032 997 1003 997
query58 220 197 190 190
query59 2403 2334 2341 2334
query60 252 212 229 212
query61 83 83 88 83
query62 583 392 376 376
query63 326 269 283 269
query64 6400 3105 3115 3105
query65 3284 3268 3266 3266
query66 1346 321 317 317
query67 14710 14331 14576 14331
query68 5120 556 569 556
query69 523 346 360 346
query70 1326 1203 1140 1140
query71 367 246 250 246
query72 6304 2787 2646 2646
query73 694 311 312 311
query74 6839 6537 6587 6537
query75 3168 2552 2540 2540
query76 3302 1178 1202 1178
query77 349 236 231 231
query78 9444 8884 8790 8790
query79 1000 502 504 502
query80 515 364 344 344
query81 400 203 202 202
query82 155 84 81 81
query83 139 123 124 123
query84 224 77 74 74
query85 760 339 331 331
query86 307 302 296 296
query87 3482 3301 3278 3278
query88 2671 2297 2263 2263
query89 429 353 369 353
query90 1941 160 165 160
query91 158 125 128 125
query92 53 47 50 47
query93 959 503 470 470
query94 1121 177 177 177
query95 469 8634 8412 8412
query96 580 270 270 270
query97 4443 4273 4258 4258
query98 231 198 198 198
query99 1115 745 708 708
Total cold run time: 269544 ms
Total hot run time: 186248 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1951956992
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1951940788
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952445224
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31109:
URL: https://github.com/apache/doris/pull/31109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952240104
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1951938214
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) make non-virtual function in Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31109:
URL: https://github.com/apache/doris/pull/31109#issuecomment-1952240032
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org