You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Jimmy-0 (via GitHub)" <gi...@apache.org> on 2026/08/23 15:58:25 UTC
[PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Jimmy-0 opened a new pull request, #23248:
URL: https://github.com/apache/kafka/pull/23248
# Description
Fix a syntax error in the validate_versions method within `benchmark_test.py`. The missing `%` operator that would cause `TypeError` is being fixed.
# Verification
- Ran a local sanity check to ensure things works correctly.
- Ran the E2E benchmark test locally, though it likely didn't exercise the failed path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Posted by "Jimmy-0 (via GitHub)" <gi...@apache.org>.
Jimmy-0 commented on PR #23248:
URL: https://github.com/apache/kafka/pull/23248#issuecomment-5396842318
@chia7712
Sorry for the delay.
Here is the End to End test result screenshot.
````
tests run: 34
passed: 34
flaky: 0
failed: 0
ignored: 0
````
<img width="1523" height="1142" alt="Screenshot 2026-08-24 at 22 39 25" src="https://github.com/user-attachments/assets/5adfaaea-2959-4192-a00e-8cd4d6d826c4" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #23248:
URL: https://github.com/apache/kafka/pull/23248#issuecomment-5392626070
LGTM, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on code in PR #23248:
URL: https://github.com/apache/kafka/pull/23248#discussion_r3844852808
##########
tests/kafkatest/benchmarks/core/benchmark_test.py:
##########
@@ -398,4 +398,4 @@ def test_share_consumer_throughput(self, compression_type="none", security_proto
return compute_aggregate_throughput(self.share_consumer)
def validate_versions(self, client_version, broker_version):
- assert client_version <= broker_version, "Client version %s should be <= than broker version %s" (client_version, broker_version)
+ assert client_version <= broker_version, "Client version %s should be <= than broker version %s" % (client_version, broker_version)
Review Comment:
nit: `"Client version %s should be <= broker version %s"` — `than` is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Posted by "yaodehaung (via GitHub)" <gi...@apache.org>.
yaodehaung commented on PR #23248:
URL: https://github.com/apache/kafka/pull/23248#issuecomment-5396288150
LGTM, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Posted by "Jimmy-0 (via GitHub)" <gi...@apache.org>.
Jimmy-0 commented on code in PR #23248:
URL: https://github.com/apache/kafka/pull/23248#discussion_r3848901241
##########
tests/kafkatest/benchmarks/core/benchmark_test.py:
##########
@@ -398,4 +398,4 @@ def test_share_consumer_throughput(self, compression_type="none", security_proto
return compute_aggregate_throughput(self.share_consumer)
def validate_versions(self, client_version, broker_version):
- assert client_version <= broker_version, "Client version %s should be <= than broker version %s" (client_version, broker_version)
+ assert client_version <= broker_version, "Client version %s should be <= than broker version %s" % (client_version, broker_version)
Review Comment:
Updated, thanks XD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix missing % operator in assertion message in benchmark_test.py [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #23248:
URL: https://github.com/apache/kafka/pull/23248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org