You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "nagasrisai (via GitHub)" <gi...@apache.org> on 2026/03/16 17:40:34 UTC

[PR] fix(ui): restore elapsed duration display for running tasks and DAG runs [airflow]

nagasrisai opened a new pull request, #63742:
URL: https://github.com/apache/airflow/pull/63742

   ## What does this PR do?
   
   Fixes the `getDuration` utility in the Airflow UI so that still-running tasks and DAG runs correctly show their elapsed duration.
   
   ## Problem
   
   After #62119, `getDuration` returns `undefined` whenever `endDate` is `null` or `undefined`. Since in-progress tasks and DAG runs have no `endDate` yet, the duration field goes completely blank in the UI — a visible regression for everyone watching a running workflow.
   
   ## Fix
   
   Only return `undefined` when **`startDate`** is missing (which is the real unrecoverable case). When `endDate` is missing, fall back to `dayjs()` (current time) so the elapsed duration is always shown for running tasks/runs.
   
   ```typescript
   // Before
   if (startDate === undefined || startDate === null || endDate === undefined || endDate === null) {
     return undefined;
   }
   const seconds = dayjs.duration(dayjs(endDate).diff(startDate)).asSeconds();
   
   // After
   if (startDate === undefined || startDate === null) {
     return undefined;
   }
   const end = endDate === undefined || endDate === null ? dayjs() : dayjs(endDate);
   const seconds = dayjs.duration(end.diff(startDate)).asSeconds();
   ```
   
   ## Tests
   
   Added two new test cases under `describe("getDuration")`:
   - Verifies that `null` / `undefined` `startDate` still returns `undefined`
   - Verifies that `null` / `undefined` `endDate` returns the elapsed duration using the current time (tested with fake timers)
   
   Closes #63602
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ui): restore elapsed duration display for running tasks and DAG runs [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #63742:
URL: https://github.com/apache/airflow/pull/63742#issuecomment-4069471599

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ui): restore elapsed duration display for running tasks and DAG runs [airflow]

Posted by "nagasrisai (via GitHub)" <gi...@apache.org>.
nagasrisai closed pull request #63742: fix(ui): restore elapsed duration display for running tasks and DAG runs
URL: https://github.com/apache/airflow/pull/63742


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ui): restore elapsed duration display for running tasks and DAG runs [airflow]

Posted by "nagasrisai (via GitHub)" <gi...@apache.org>.
nagasrisai commented on PR #63742:
URL: https://github.com/apache/airflow/pull/63742#issuecomment-4084292402

   This issue was resolved by another commit 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org