[GitHub] mbeckerle opened a new pull request #152: Daffodil 2028 cross test

[GitBox <gi...@apache.org>]

mbeckerle opened a new pull request #152: Daffodil 2028 cross test
URL: https://github.com/apache/incubator-daffodil/pull/152
 
 
   This is a partial step that improves portability of daffodil-test, but is not completing the job yet. 
   But this much can be changed without any large-scale regressions, so is worth reviiew separately.
       
       Changed explicit use of encodingErrorPolicy in tests to
       encodingErrorPolicy="error" for all tests except those
       explicitly testing replace policy, and those are now restricted to
       implementation 'daffodil'.
       
       Changed explicit use of calendarTimeZone="" to calendarTimeZone="UTC" or other except
       for tests that are explicitly testing for no time zone. Those tests are
       implementation 'daffodil' only.
       
       Did NOT change GeneralFormat. A new format GeneralFormatForCrossTesting
       is available which has encodingErrorPolicy 'error' and
       calendarTimeZone='UTC' for future convenience. But this was not put in place
      across daffodil-test tests yet, because of 135 regressions that it causes. 
       
      TDML Runner doesn't cross test negative tests by default.
       
       It still runs the tests, just doesn't compare the messages.
       So the test still has to fail, just without scrutinizing the diagnostic
       messages.
       
   By passing parameters to DFDLTestCase you can override this and create
   tests which are designed to verify cross-test error message text or
   warning text.
       
   Also doesn't verify warnings on cross tests (negative or positive)
   unless parameters are set.
         
   Portable tests should use GeneralFormatForCrossTesting
   This was NOT put in place across daffodil-test however, as it causes 135 tests to break (11 due to encodingErrorPolicy='error', and the rest due to time-zone strings needing to appear in infoset due to calendarTimeZone="UTC". Those changes are not in this PR, as they should be done in conjunction with also fixing DAFFODIL-2026 which means not just adding the TZ strings, but also xsi:type attributes so tests can do type-specific comparison. 
   
   So this is a partial step that improves portability of daffodil-test, but is not completing the job yet. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services