You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Alan M. Carroll (JIRA)" <ji...@apache.org> on 2010/10/21 00:02:24 UTC
[jira] Created: (TS-493) Return value from pcre_exec tested
incorrectly
Return value from pcre_exec tested incorrectly
----------------------------------------------
Key: TS-493
URL: https://issues.apache.org/jira/browse/TS-493
Project: Traffic Server
Issue Type: Bug
Affects Versions: 2.1.3
Reporter: Alan M. Carroll
Priority: Minor
Fix For: 2.1.4
proxy/ControlMatcher.cc:371
The return value of pcre_exec is checked against -1 for error. However, the return value -1 means "not found" which is not actually an error. If there is an error, different negative values are returned which this logic will interpret as success.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-493) Return value from pcre_exec tested
incorrectly
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll resolved TS-493.
--------------------------------
Resolution: Fixed
Patch committed r1026197
> Return value from pcre_exec tested incorrectly
> ----------------------------------------------
>
> Key: TS-493
> URL: https://issues.apache.org/jira/browse/TS-493
> Project: Traffic Server
> Issue Type: Bug
> Affects Versions: 2.1.3
> Reporter: Alan M. Carroll
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 2.1.4
>
>
> proxy/ControlMatcher.cc:371
> The return value of pcre_exec is checked against -1 for error. However, the return value -1 means "not found" which is not actually an error. If there is an error, different negative values are returned which this logic will interpret as success.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-493) Return value from pcre_exec tested
incorrectly
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll reassigned TS-493:
----------------------------------
Assignee: Alan M. Carroll
> Return value from pcre_exec tested incorrectly
> ----------------------------------------------
>
> Key: TS-493
> URL: https://issues.apache.org/jira/browse/TS-493
> Project: Traffic Server
> Issue Type: Bug
> Affects Versions: 2.1.3
> Reporter: Alan M. Carroll
> Assignee: Alan M. Carroll
> Priority: Minor
> Fix For: 2.1.4
>
>
> proxy/ControlMatcher.cc:371
> The return value of pcre_exec is checked against -1 for error. However, the return value -1 means "not found" which is not actually an error. If there is an error, different negative values are returned which this logic will interpret as success.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-493) Return value from pcre_exec tested
incorrectly
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923192#action_12923192 ]
Alan M. Carroll commented on TS-493:
------------------------------------
It is currently unknown which, if any, version of PCRE returned -1 as a general error. It is possible that this is inherited from previous work and was never correct.
> Return value from pcre_exec tested incorrectly
> ----------------------------------------------
>
> Key: TS-493
> URL: https://issues.apache.org/jira/browse/TS-493
> Project: Traffic Server
> Issue Type: Bug
> Affects Versions: 2.1.3
> Reporter: Alan M. Carroll
> Priority: Minor
> Fix For: 2.1.4
>
>
> proxy/ControlMatcher.cc:371
> The return value of pcre_exec is checked against -1 for error. However, the return value -1 means "not found" which is not actually an error. If there is an error, different negative values are returned which this logic will interpret as success.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.