You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:27:22 UTC
[GitHub] [airflow] fabien-sarcel opened a new pull request #10056: Fix typo on reattach property of kubernetespodoperator
fabien-sarcel opened a new pull request #10056:
URL: https://github.com/apache/airflow/pull/10056
related: #10021
Fix typo in KubernetesPodOperator to get the expected behavior of reattach property
From #10021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-667167129
@fabien-sarcel I restarted all the builds and all seem to be green π’
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fabien-sarcel commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
fabien-sarcel commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-667095185
@turbaszek I did the rebase, but it still doesn't work. Look like a CI timeout. Any idea ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-667167399
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #10056:
URL: https://github.com/apache/airflow/pull/10056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-667036456
@fabien-sarcel would you mind rebasing? It seems that @kaxil fixed the k8s tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-666169189
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fabien-sarcel commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
fabien-sarcel commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-666230750
Kubernetes tests are ok with my local Breeze, I don't know why the ci_run_kubernetes_tests.sh script doesn't work with CI ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-666356773
hmm tests are failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] danccooper commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
danccooper commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-668852500
Nice! Thanks @fabien-sarcel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10056: Fix typo on reattach property of kubernetespodoperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10056:
URL: https://github.com/apache/airflow/pull/10056#issuecomment-666357431
CI failure might be unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org