You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2014/06/03 17:03:01 UTC
[jira] [Updated] (HTTPCLIENT-1434) TrustSelfSignedStrategy should
be a singleton
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-1434:
------------------------------------------
Fix Version/s: (was: 4.4 Final)
4.4 Alpha1
> TrustSelfSignedStrategy should be a singleton
> ---------------------------------------------
>
> Key: HTTPCLIENT-1434
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1434
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.3.1
> Reporter: Sebastiano Vigna
> Priority: Trivial
> Fix For: 4.4 Alpha1
>
>
> TrustSelfSignedStrategy should be a singleton, as it happens for several other strategies in HTTP Client. For example,
> public class TrustSelfSignedStrategy implements TrustStrategy {
> public static final TrustSelfSignedStrategy INSTANCE = new TrustSelfSignedStrategy();
> private TrustSelfSignedStrategy() {}
> public boolean isTrusted(
> final X509Certificate[] chain, final String authType) throws CertificateException {
> return chain.length == 1;
> }
> }
> Incidentally, I noted that other strategies (e.g., NoConnectionReuseStrategy) have a public constructor, which violates the Singleton design pattern.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org