You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/31 08:39:09 UTC

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Spaceman1984 opened a new pull request #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004
 
 
   ## Description
   <!--- Describe your changes in detail -->
   This PR fixes an issue where an instance fails to deploy due to a null pointer when using a L2 Guest Network with DefaultL2NetworkOfferingConfigDrive on Xenserver.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   This has been tested by: 
   - Creating a L2 Guest network, using DefaultL2NetworkOfferingConfigDrive as the network offering. 
   - Deploying an instance using the L2 Guest network created.
   
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] Spaceman1984 commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-606485735
 
 
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-612138727
 
 
   <b>Trillian test result (tid-1402)</b>
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35354 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4004-t1402-xenserver-65sp1.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 272.70 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 256.84 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 402.47 | test_privategw_acl.py
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-611266132
 
 
   @blueorangutan test centos7 xenserver-65sp1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-611266460
 
 
   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#discussion_r410109502
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##########
 @@ -1156,7 +1156,7 @@ public VBD createVbd(final Connection conn, final DiskTO volume, final String vm
         if (volume.getType() == Volume.Type.ISO) {
             vbdr.mode = Types.VbdMode.RO;
             vbdr.type = Types.VbdType.CD;
-            vbdr.userdevice = "3";
+            vbdr.userdevice = String.valueOf(3 + isoCount);
 
 Review comment:
   @DaanHoogland I have made the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#discussion_r407034069
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##########
 @@ -1156,7 +1156,7 @@ public VBD createVbd(final Connection conn, final DiskTO volume, final String vm
         if (volume.getType() == Volume.Type.ISO) {
             vbdr.mode = Types.VbdMode.RO;
             vbdr.type = Types.VbdType.CD;
-            vbdr.userdevice = "3";
+            vbdr.userdevice = String.valueOf(3 + isoCount);
 
 Review comment:
   maybe give the 3 a constant with descriptive name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-606486288
 
 
   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4004: Fixed null pointer and deployment issue on Xenserver and L2 Guest network with configDrive
URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-606495414
 
 
   Packaging result: ✔centos7 ✔debian. JID-1109

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services