You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/01/09 03:16:57 UTC

[GitHub] upgle opened a new pull request #4211: Add originPath annotation to record the not resolved action path

upgle opened a new pull request #4211: Add originPath annotation to record the not resolved action path
URL: https://github.com/apache/incubator-openwhisk/pull/4211
 
 
   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   
   If the user invokes an action in a package binding, they can't know action path from which action is invoked. because current activation structure only records the resolved action path.
   
   for example, suppose we have the following entities:
   
   - `package` : **pkg1**
      - `action` : pkg1/**action1**
   - `package` **pkg2** bind **pkg1**
   - `package` **pkg3** bind **pkg1**
   
   If user invokes the pkg2/action1 action and the pkg3/action1 action, all path annotations of invoked action in binding packages are saved as **namespace/pkg1/action1**.
   
   ```json
       "annotations": [
           {
               "key": "path",
               "value": "namespace/pkg1/action1"
           },
        ]
   ```
   
   ## Suggestion
   
   So i added an annotation to distinguish between resolved action path and invoked action path and opend this PR.
   
   ```json
   {
       "activationId": "f4250bb2721d4e4ca50bb2721d2e4cdd",
       "annotations": [
           {
               "key": "path",
               "value": "namespace/pkg1/action1"
           },
           {
               "key": "originPath",
               "value": "namespace/pkg2/action1"
           }
       ]
   }
   ```
   
   
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services