You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "joyyir (via GitHub)" <gi...@apache.org> on 2023/05/23 09:57:39 UTC

[GitHub] [apisix] joyyir opened a new issue, #9531: feat: Check external plugin readiness on APISIX startup

joyyir opened a new issue, #9531:
URL: https://github.com/apache/apisix/issues/9531

   ### Description
   
   I got a `503` response when I sent a request when apisix is ready and external plugin is not ready.
   The current version of apisix helm chart uses [`tcpSocket` for readiness probe](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/_pod.tpl#L108), but this is not sufficient when using external plugins as it does not check readiness of external plugins.
   In my opinion, A mechanism is needed which check the readiness of external plugin on APISIX startup time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] jiangfucheng commented on issue #9531: feat: Check external plugin readiness on APISIX startup

Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng commented on issue #9531:
URL: https://github.com/apache/apisix/issues/9531#issuecomment-1644141885

   In current logic, APISIX will create `ext-plugin` child process in `init_worker` phase, if the child process start failed, it will print error logs and try to restart the `ext-plugin` process.
   
   Check the child process if alive is easy, but it seems complicated to stop nginx in `init_worker` phase.
   Do you have any suggestions?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org