You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/13 08:04:09 UTC
[GitHub] [shenyu] 847850277 opened a new pull request, #4263: [ISSUE #4029] add shenyu-client-api-doc
847850277 opened a new pull request, #4263:
URL: https://github.com/apache/shenyu/pull/4263
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on PR #4263:
URL: https://github.com/apache/shenyu/pull/4263#issuecomment-1348219046
There are too many files changed. Please split them into at least 3 PRs, and complete client, example, and admin respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on a diff in pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #4263:
URL: https://github.com/apache/shenyu/pull/4263#discussion_r1047003552
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/ApiServiceImpl.java:
##########
@@ -175,4 +175,25 @@ public CommonPager<ApiVO> listByPage(final ApiQuery apiQuery) {
return ApiVO.buildApiVO(item, tagVOS);
}).collect(Collectors.toList()));
}
+
+ @Override
+ public int deleteByApiPathHttpMethodRpcType(final String apiPath, final Integer httpMethod, final String rpcType) {
+ List<ApiDO> apiDOs = apiMapper.selectByApiPathHttpMethodRpcType(apiPath, httpMethod, rpcType);
+ // delete apis.
+ if (CollectionUtils.isNotEmpty(apiDOs)) {
+ final List<String> apiIds = ListUtil.map(apiDOs, ApiDO::getId);
+ final int deleteRows = this.apiMapper.deleteByIds(apiIds);
+ if (deleteRows > 0) {
+ tagRelationMapper.deleteByApiIds(apiIds);
+ }
+ return deleteRows;
+ }
+ return 0;
+ }
+
+ @Override
+ public String offlineByContextPath(final String contextPath) {
+ apiMapper.updateOfflineByContextPath(contextPath);
Review Comment:
There are many nodes in the service. Only when all nodes are offline can the API status be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] 847850277 commented on pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
Posted by GitBox <gi...@apache.org>.
847850277 commented on PR #4263:
URL: https://github.com/apache/shenyu/pull/4263#issuecomment-1350430773
> Please split this PR into at least 3 PRs.
It will be solved when I'm empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4263:
URL: https://github.com/apache/shenyu/pull/4263#issuecomment-1347957824
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4263?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4263](https://codecov.io/gh/apache/shenyu/pull/4263?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (996be1e) into [master](https://codecov.io/gh/apache/shenyu/commit/e60d93ef426bc168435920e5e1f622ba6e74ceb9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e60d93e) will **decrease** coverage by `0.98%`.
> The diff coverage is `18.25%`.
> :exclamation: Current head 996be1e differs from pull request most recent head 04b14c3. Consider uploading reports for the commit 04b14c3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4263 +/- ##
============================================
- Coverage 69.48% 68.50% -0.99%
+ Complexity 7380 7355 -25
============================================
Files 995 997 +2
Lines 27984 28332 +348
Branches 2476 2514 +38
============================================
- Hits 19444 19408 -36
- Misses 7061 7447 +386
+ Partials 1479 1477 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...controller/ShenyuClientHttpRegistryController.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVDbGllbnRIdHRwUmVnaXN0cnlDb250cm9sbGVyLmphdmE=) | `63.63% <0.00%> (-14.15%)` | :arrow_down: |
| [...uptor/executor/RegisterServerConsumerExecutor.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL2V4ZWN1dG9yL1JlZ2lzdGVyU2VydmVyQ29uc3VtZXJFeGVjdXRvci5qYXZh) | `14.28% <0.00%> (-0.43%)` | :arrow_down: |
| [...ache/shenyu/admin/service/impl/ApiServiceImpl.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0FwaVNlcnZpY2VJbXBsLmphdmE=) | `37.03% <0.00%> (-5.22%)` | :arrow_down: |
| [.../register/FallbackShenyuClientRegisterService.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9GYWxsYmFja1NoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZS5qYXZh) | `11.11% <ø> (ø)` | |
| [.../service/register/ShenyuClientRegisterService.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...client/brpc/BrpcContextRefreshedEventListener.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWJycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvYnJwYy9CcnBjQ29udGV4dFJlZnJlc2hlZEV2ZW50TGlzdGVuZXIuamF2YQ==) | `80.64% <0.00%> (-1.33%)` | :arrow_down: |
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `66.66% <ø> (ø)` | |
| [.../apache/shenyu/common/enums/ApiHttpMethodEnum.java](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9lbnVtcy9BcGlIdHRwTWV0aG9kRW51bS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/shenyu/pull/4263/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on a diff in pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #4263:
URL: https://github.com/apache/shenyu/pull/4263#discussion_r1047009492
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/AbstractShenyuClientRegisterServiceImpl.java:
##########
@@ -54,53 +60,58 @@
* Abstract strategy.
*/
public abstract class AbstractShenyuClientRegisterServiceImpl extends FallbackShenyuClientRegisterService implements ShenyuClientRegisterService {
-
+
+ private static final Logger LOG = LoggerFactory.getLogger(AbstractShenyuClientRegisterServiceImpl.class);
+
/**
* The Event publisher.
*/
@Resource
private ApplicationEventPublisher eventPublisher;
-
+
/**
* The Selector service.
*/
@Resource
private SelectorService selectorService;
-
+
@Resource
private MetaDataService metaDataService;
-
+
/**
* The Rule service.
*/
@Resource
private RuleService ruleService;
-
Review Comment:
do not change the format, try config format in your IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] 847850277 closed pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
Posted by GitBox <gi...@apache.org>.
847850277 closed pull request #4263: [ISSUE #4029] add shenyu-client-api-doc
URL: https://github.com/apache/shenyu/pull/4263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org