You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "jlaitine (via GitHub)" <gi...@apache.org> on 2025/06/05 05:44:45 UTC

[PR] Fix arch perf events ifdef in alarm [nuttx]

jlaitine opened a new pull request, #16487:
URL: https://github.com/apache/nuttx/pull/16487

   
   ## Summary
   
   This fixes the ifdef in drivers/timers/arch_alarm.c, which may cause linking errors when architecture defines up_perf_* functions, but doesn't enable ARCH_PERF_EVENTS.
   
   ## Impact
   
   Doesn't impact functionality, compilation fix
   
   ## Testing
   
   Tested on icicle:opensbi target
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arch perf events ifdef in alarm [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #16487:
URL: https://github.com/apache/nuttx/pull/16487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arch perf events ifdef in alarm [nuttx]

Posted by "jlaitine (via GitHub)" <gi...@apache.org>.
jlaitine commented on PR #16487:
URL: https://github.com/apache/nuttx/pull/16487#issuecomment-2942967366

   No, it is a mess. I'll give it one more try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arch perf events ifdef in alarm [nuttx]

Posted by "jlaitine (via GitHub)" <gi...@apache.org>.
jlaitine commented on PR #16487:
URL: https://github.com/apache/nuttx/pull/16487#issuecomment-2943057764

   Now, if this works I still need to squash the first and third patch; otherwise there is a non-compiling point in the middle for many targets preventing e.g. bisecting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org