[GitHub] [activemq-nms-amqp] lukeabsent commented on a change in pull request #68: Amqnet 637

[GitBox <gi...@apache.org>]

lukeabsent commented on a change in pull request #68:
URL: https://github.com/apache/activemq-nms-amqp/pull/68#discussion_r678448642



##########
File path: test/Apache-NMS-AMQP-Test/Integration/TransactionsIntegrationTest.cs
##########
@@ -997,6 +997,12 @@ public void TestSendAfterCoordinatorLinkClosedDuringTX()
 
                 testPeer.WaitForAllMatchersToComplete(2000);
 
+                // Make sure that above line 'WaitForAllMatchersToComplete' also finishes on session/producer side
+                // In order for producer.Send to not really send, transaction on this end needs to be IsTransactionFailed
+                // in AmqpProducer  if (session.IsTransacted && session.IsTransactionFailed), and sometimes producer.Send tries
+                // to send before this flag is set, which would cause actual transfer
+                Thread.Sleep(10);

Review comment:
       I dont see much options here, the way I see it for test to go expected way, that flag mentioned in comment should switch, but I dont see any nice way of checking/waiting for it here and signal : /




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org