You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/05 17:34:17 UTC
[GitHub] [incubator-echarts] plainheart opened a new pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
plainheart opened a new pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Sunburst series supports corner radius in ECharts, please refer to #13123 & #13378 for more details.
### Fixed issues
- #13378 (partial)
## Details
## Usage
### Are there any API changes?
- [x] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
Added a new option to the sunburst series.
- **cornerRadius** (can be a string/number/string array/number array)
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
#13378 - Pie series supports cornerRadius
fe0d94a - Treemap series supports borderRadius
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
100pah edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705496149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705536378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705536378
> Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
I thought about the naming at first.
Though I would like to name it after `borderRadius` to keep naming uniform, I think `cornerRadius` is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it `cornerRadius`, such as [amcharts](https://www.amcharts.com/docs/v4/reference/slice/#cornerRadius_property), [d3](https://github.com/d3/d3-shape#arc_cornerRadius).
However, on the contrary, `borderRadius` is more corresponding with the naming of `border` in CSS.
I'm afraid it's hard for me to decide to use which one.
> Should `cornerRadius` be set in `itemStyle` as `borderColor` `borderWidth` did or set in the root of `series`? Probably it's better to follow the convention to put it in `itemStyle`?
I think it's generally okay. Putting `cornerRadius` into `itemStyle` may enable users to control easily style of each item(sector).
That looks better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-704007773
The result is beautiful. Great job!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
100pah commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705496149
Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
Currently we have `borderColor` `borderWidth` that the same as CSS naming.
`borderRaidus` may be easy to remember a little. But `cornerRadius` seem more semantically correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
100pah commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705496149
Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
Currently we have `borderColor` `borderWidth` that the same as CSS naming.
`borderRaidus` may be easy to remember a little. But `cornerRadius` seem more semantically correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-704008684
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705536378
> Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
I thought about the naming at first.
Though I would like to name it after `borderRadius` to keep naming uniform, I think `cornerRadius` is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it `cornerRadius`, such as [amcharts](https://www.amcharts.com/docs/v4/reference/slice/#cornerRadius_property), [d3](https://github.com/d3/d3-shape#arc_cornerRadius).
However, on the contrary, `borderRadius` is more corresponding with the naming of `border` in CSS and many options in ECharts are currently using this kind of naming.
I'm afraid it's hard for me to decide to use which one.
> Should `cornerRadius` be set in `itemStyle` as `borderColor` `borderWidth` did or set in the root of `series`? Probably it's better to follow the convention to put it in `itemStyle`?
I think it's generally okay. Putting `cornerRadius` into `itemStyle` may enable users to control easily style of each item(sector).
That looks better.
@100pah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705978269
> Though I would like to name it after borderRadius to keep naming uniform, I think cornerRadius is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it cornerRadius, such as amcharts, d3.
However, on the contrary, borderRadius is more corresponding with the naming of border in CSS and many options in ECharts are currently using this kind of naming.
Almost the same concern. But I think a uniform naming is slightly better after struggling with my mind.
@plainheart Are you planning to do these two changes? I'm fine to do this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705536378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705978269
> Though I would like to name it after borderRadius to keep naming uniform, I think cornerRadius is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it cornerRadius, such as amcharts, d3.
However, on the contrary, borderRadius is more corresponding with the naming of border in CSS and many options in ECharts are currently using this kind of naming.
Almost the same concern. But I think a uniform naming is slightly better after struggling with my mind.
@plainheart Are you planning to do these two changes? I'm fine to do this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705978269
> Though I would like to name it after borderRadius to keep naming uniform, I think cornerRadius is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it cornerRadius, such as amcharts, d3.
However, on the contrary, borderRadius is more corresponding with the naming of border in CSS and many options in ECharts are currently using this kind of naming.
Almost the same concern. But I think a uniform naming is slightly better after struggling with my mind.
@plainheart Are you planning to do these two changes? I'm fine to do this work today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-703779187
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
Document changes are required in this PR. Please also make a PR to [apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
100pah edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705496149
+ Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
Currently we have `borderColor` `borderWidth` that the same as CSS naming.
`borderRaidus` may be easy to remember a little. But `cornerRadius` seem more semantically correct.
+ Should `cornerRadius` be set in `itemStyle` as `borderColor` `borderWidth` did or set in the root of `series`? Probably it's better to follow the convention to put it in `itemStyle`?
@pissang @plainheart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705986284
@pissang No. I'm glad that you are going to help me do this. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
100pah edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705496149
Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
Currently we have `borderColor` `borderWidth` that the same as CSS naming.
`borderRaidus` may be easy to remember a little. But `cornerRadius` seem more semantically correct.
@pissang @plainheart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705536378
> Do we name it as `borderRaidus` as CSS did or name it as `cornerRadius`?
I thought about the naming at first.
Though I would like to name it after `borderRadius` to keep naming uniform, I think `cornerRadius` is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it `cornerRadius`, such as [amcharts](https://www.amcharts.com/docs/v4/reference/slice/#cornerRadius_property), [d3](https://github.com/d3/d3-shape#arc_cornerRadius).
However, on the contrary, `borderRadius` is more corresponding with the naming of `border` in CSS.
I'm afraid it's hard for me to decide to use which one.
> Should `cornerRadius` be set in `itemStyle` as `borderColor` `borderWidth` did or set in the root of `series`? Probably it's better to follow the convention to put it in `itemStyle`?
I think it's generally okay. Putting `cornerRadius` into `itemStyle` may enable users to control easily style of each item(sector).
That looks better.
@100pah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705978269
> Though I would like to name it after borderRadius to keep naming uniform, I think cornerRadius is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it cornerRadius, such as amcharts, d3.
However, on the contrary, borderRadius is more corresponding with the naming of border in CSS and many options in ECharts are currently using this kind of naming.
Almost the same concern. But I think a uniform naming is slightly better after struggling with my mind.
@plainheart Are you planning to do these two changes? I'm fine to do this work today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org