You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/18 11:03:29 UTC

[GitHub] [cordova-plugin-camera] guillem-sopra opened a new pull request #549: fix(ios): handle video transcoding cancel exception

guillem-sopra opened a new pull request #549: fix(ios): handle video transcoding cancel exception
URL: https://github.com/apache/cordova-plugin-camera/pull/549
 
 
   Closes https://github.com/apache/cordova-plugin-camera/issues/545
   
   If the video transcoding process is interrupted (generally by the user), an empty string is returned as file uri.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-camera] timbru31 commented on a change in pull request #549: fix(ios): handle video transcoding cancel exception

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #549: fix(ios): handle video transcoding cancel exception
URL: https://github.com/apache/cordova-plugin-camera/pull/549#discussion_r371532532
 
 

 ##########
 File path: src/ios/CDVCamera.m
 ##########
 @@ -512,8 +512,13 @@ - (void)resultForImage:(CDVPictureOptions*)options info:(NSDictionary*)info comp
 
 - (CDVPluginResult*)resultForVideo:(NSDictionary*)info
 {
-    NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] absoluteString];
-    return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:moviePath];
+    @try {
+        NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] absoluteString];
+        return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:moviePath];
+    } @catch (NSException *exception) {
+        NSLog(@"Camera.resultForVideo: error retrieving file path");
+        return [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:@""];
 
 Review comment:
   Great, one minor request: Could you pass in the exception message into the Cordova callback?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-camera] guillem-sopra commented on a change in pull request #549: fix(ios): handle video transcoding cancel exception

Posted by GitBox <gi...@apache.org>.
guillem-sopra commented on a change in pull request #549: fix(ios): handle video transcoding cancel exception
URL: https://github.com/apache/cordova-plugin-camera/pull/549#discussion_r407197320
 
 

 ##########
 File path: src/ios/CDVCamera.m
 ##########
 @@ -512,8 +512,13 @@ - (void)resultForImage:(CDVPictureOptions*)options info:(NSDictionary*)info comp
 
 - (CDVPluginResult*)resultForVideo:(NSDictionary*)info
 {
-    NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] absoluteString];
-    return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:moviePath];
+    @try {
+        NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] absoluteString];
+        return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:moviePath];
+    } @catch (NSException *exception) {
+        NSLog(@"Camera.resultForVideo: error retrieving file path");
+        return [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:@""];
 
 Review comment:
   Sorry for the late response, I left the company I was working in at the time and lost the email account, and also access to this github account. All should be fine now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-camera] timbru31 commented on issue #549: fix(ios): handle video transcoding cancel exception

Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #549: fix(ios): handle video transcoding cancel exception
URL: https://github.com/apache/cordova-plugin-camera/pull/549#issuecomment-613004749
 
 
   Great! I'll give this a review and try tomorrow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org