[jira] [Commented] (CXF-6720) AbstractHTTPDestination#WrappedOutputStream.close() calls flush after close

["Akitoshi Yoshida (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066354#comment-15066354 ] 

Akitoshi Yoshida commented on CXF-6720:
---------------------------------------

Memo
this close and flush was added with this
http://svn.apache.org/viewvc?view=revision&revision=548549

I think we can remove the flushBuffer line as I suppose the close on the stream will be flushing the response buffer.
But I don't know if there is a case that is not the case and this flushBuffer needs to be called.
In that case, we might need to keep it with some condition/protection (e.g. checking !response.isCommitted() before or catching the unexpected exception).

Dan, how do you think?

> AbstractHTTPDestination#WrappedOutputStream.close() calls flush after close
> ---------------------------------------------------------------------------
>
>                 Key: CXF-6720
>                 URL: https://issues.apache.org/jira/browse/CXF-6720
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.7.18, 3.0.7, 3.1.4
>         Environment: IBM Liberty Profile with CXF and JavaMelody, but this is mostly a discussion about Servlet/Flushable-spec and flush after close.
>            Reporter: John Hestad
>            Priority: Minor
>              Labels: Closable, Flushable, IBM_JAVA, JavaMelody, LibertyProfile, OutputStream, core, flush, flushBuffer, servlet-api
>
> Bug location: https://github.com/apache/cxf/blob/master/rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java#L806
> ServletResponse.flushBuffer: http://grepcode.com/file/repo1.maven.org/maven2/javax.servlet/javax.servlet-api/3.1.0/javax/servlet/ServletResponse.java#ServletResponse.flushBuffer%28%29
> Reading the javadoc of ServletResponse.flushBuffer, Closable and Flushable interfaces tells me that calling flushBuffer on a ServletResponse containing a  closed stream could give an IOException.
> We have had problems with this in Liberty Profile, while using CXF together with CXF.
> Background story:
> 1) https://github.com/javamelody/javamelody/issues/411
> 2) https://groups.google.com/forum/#!topic/javamelody/kX31sRTFrHE/discussion
> 3) http://www-01.ibm.com/support/docview.wss?uid=swg1PI46480
> To make a short recap:
> 1) Soap-call to the service
> 2) Cxf calls close()  -> OutputStream closes
> 3) Cxf calls flushBuffer which hits JavaMelody's ServletResponse-wrapper which again calls flush on the OutputStream
> 4) Ibm Liberty Profile throws an IOException telling the stream is closed.
> If we exclude JavaMelody:
> 3) Cxf calls flushBuffer which hits Liberty Profile's ServletResponse-wrapper which checks if the stream is already close and returns early.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)