You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by wa...@apache.org on 2018/08/07 20:06:38 UTC
hadoop git commit: YARN-8407. Container launch exception in AM log
should be printed in ERROR level. (Yesha Vora via wangda)
Repository: hadoop
Updated Branches:
refs/heads/trunk c0599151b -> 861095f76
YARN-8407. Container launch exception in AM log should be printed in ERROR level. (Yesha Vora via wangda)
Change-Id: I154e873df1df3503a09c41d6b3874ca195af91d9
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/861095f7
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/861095f7
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/861095f7
Branch: refs/heads/trunk
Commit: 861095f761b40171e0dc25f769f486d910cc3e88
Parents: c059915
Author: Wangda Tan <wa...@apache.org>
Authored: Tue Aug 7 13:01:13 2018 -0700
Committer: Wangda Tan <wa...@apache.org>
Committed: Tue Aug 7 13:01:13 2018 -0700
----------------------------------------------------------------------
.../component/instance/ComponentInstance.java | 22 +++++++++++++-------
1 file changed, 14 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/861095f7/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java
index 3499d92..10128a0 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java
@@ -256,14 +256,20 @@ public class ComponentInstance implements EventHandler<ComponentInstanceEvent>,
// re-ask the failed container.
comp.requestContainers(1);
comp.reInsertPendingInstance(compInstance);
- LOG.info(compInstance.getCompInstanceId()
- + ": {} completed. Reinsert back to pending list and requested " +
- "a new container." + System.lineSeparator() +
- " exitStatus={}, diagnostics={}.",
- event.getContainerId(), failureBeforeLaunch ? null :
- event.getStatus().getExitStatus(),
- failureBeforeLaunch ? FAILED_BEFORE_LAUNCH_DIAG :
- event.getStatus().getDiagnostics());
+
+ StringBuilder builder = new StringBuilder();
+ builder.append(compInstance.getCompInstanceId()).append(": ");
+ builder.append(event.getContainerId()).append(" completed. Reinsert back to pending list and requested ");
+ builder.append("a new container.").append(System.lineSeparator());
+ builder.append(" exitStatus=").append(failureBeforeLaunch ? null : event.getStatus().getExitStatus());
+ builder.append(", diagnostics=");
+ builder.append(failureBeforeLaunch ? FAILED_BEFORE_LAUNCH_DIAG : event.getStatus().getDiagnostics());
+
+ if (event.getStatus().getExitStatus() != 0) {
+ LOG.error(builder.toString());
+ } else {
+ LOG.info(builder.toString());
+ }
} else {
// When no relaunch, update component's #succeeded/#failed
// instances.
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org