You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/20 12:03:58 UTC
[jira] [Commented] (THRIFT-4009) Use @implementer instead of
implements in TTwisted.py
[ https://issues.apache.org/jira/browse/THRIFT-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764050#comment-15764050 ]
ASF GitHub Bot commented on THRIFT-4009:
----------------------------------------
GitHub user ciarancourtney opened a pull request:
https://github.com/apache/thrift/pull/1142
THRIFT-4009: Use @implementer instead of implements in TTwisted.py
* As per zope.interface 4.0.0 changelog
Deprecate the “class advice” APIs from zope.interface.declarations: implements, implementsOnly, and classProvides. In their place, prefer the equivalent class decorators: @implementer, @implementer_only, and @provider. Code which uses the deprecated APIs will not work as expected under Py3k.
https://pypi.python.org/pypi/zope.interface
Patch is simply output of zope-2to3 -wn lib/py/src/transport/TTwisted.py
All tests passed incl cross lang suite. Should be py2/3 compat
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ciarancourtney/thrift THRIFT-4009-use-implementer-decorator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1142
----
commit 121be3b5f8319bd6cb3421a850c04652105a7add
Author: ciarancourtney <ci...@cylon.com>
Date: 2016-12-20T11:12:15Z
THRIFT-4009: Use @implementer instead of implements in TTwisted.py
* As per zope.interface 4.0.0 changelog
Deprecate the “class advice” APIs from zope.interface.declarations: implements, implementsOnly, and classProvides. In their place, prefer the equivalent class decorators: @implementer, @implementer_only, and @provider. Code which uses the deprecated APIs will not work as expected under Py3k.
https://pypi.python.org/pypi/zope.interface
Patch is simply output of zope-2to3 -wn lib/py/src/transport/TTwisted.py
----
> Use @implementer instead of implements in TTwisted.py
> -----------------------------------------------------
>
> Key: THRIFT-4009
> URL: https://issues.apache.org/jira/browse/THRIFT-4009
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.9.3
> Reporter: Ciaran Courtney
> Priority: Minor
> Labels: easyfix, newbie
> Fix For: 0.10.0
>
>
> As per zope.interface 4.0.0 changelog
> {quote}
> * Deprecate the “class advice” APIs from zope.interface.declarations: implements, implementsOnly, and classProvides. In their place, prefer the equivalent class decorators: @implementer, @implementer_only, and @provider. Code which uses the deprecated APIs will not work as expected under Py3k.
> {quote}
> https://pypi.python.org/pypi/zope.interface
> PR incoming, patch is simply output of {{zope-2to3 -wn lib/py/src/transport/TTwisted.py}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)