You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sk0x50 (via GitHub)" <gi...@apache.org> on 2023/05/23 10:26:13 UTC
[GitHub] [ignite-3] sk0x50 opened a new pull request, #2097: IGNITE-19533 Renamed UNKNOWN_ERR error code to INTERNAL_ERR. Removed UNEXPECTED_ERR error code.
sk0x50 opened a new pull request, #2097:
URL: https://github.com/apache/ignite-3/pull/2097
https://issues.apache.org/jira/browse/IGNITE-19533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sk0x50 merged pull request #2097: IGNITE-19533 Renamed UNKNOWN_ERR error code to INTERNAL_ERR. Removed UNEXPECTED_ERR error code.
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #2097:
URL: https://github.com/apache/ignite-3/pull/2097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2097: IGNITE-19533 Renamed UNKNOWN_ERR error code to INTERNAL_ERR. Removed UNEXPECTED_ERR error code.
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #2097:
URL: https://github.com/apache/ignite-3/pull/2097#discussion_r1203870541
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -27,24 +27,23 @@ public static class Common {
/** Unknown error group. */
Review Comment:
Unknown here is probably a typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2097: IGNITE-19533 Renamed UNKNOWN_ERR error code to INTERNAL_ERR. Removed UNEXPECTED_ERR error code.
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #2097:
URL: https://github.com/apache/ignite-3/pull/2097#discussion_r1203875337
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -27,24 +27,23 @@ public static class Common {
/** Unknown error group. */
Review Comment:
Nice catch! Will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2097: IGNITE-19533 Renamed UNKNOWN_ERR error code to INTERNAL_ERR. Removed UNEXPECTED_ERR error code.
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #2097:
URL: https://github.com/apache/ignite-3/pull/2097#discussion_r1203872530
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -27,24 +27,23 @@ public static class Common {
/** Unknown error group. */
public static final ErrorGroup COMMON_ERR_GROUP = ErrorGroup.newGroup("CMN", 1);
- /** Unexpected error. */
- public static final int UNEXPECTED_ERR = COMMON_ERR_GROUP.registerErrorCode(1);
-
/** Node stopping error. */
- public static final int NODE_STOPPING_ERR = COMMON_ERR_GROUP.registerErrorCode(2);
+ public static final int NODE_STOPPING_ERR = COMMON_ERR_GROUP.registerErrorCode(1);
/** Component not started error. */
- public static final int COMPONENT_NOT_STARTED_ERR = COMMON_ERR_GROUP.registerErrorCode(3);
+ public static final int COMPONENT_NOT_STARTED_ERR = COMMON_ERR_GROUP.registerErrorCode(2);
/** Illegal argument or argument in a wrong format has been passed. */
- public static final int ILLEGAL_ARGUMENT_ERR = COMMON_ERR_GROUP.registerErrorCode(4);
+ public static final int ILLEGAL_ARGUMENT_ERR = COMMON_ERR_GROUP.registerErrorCode(3);
/** SSL can not be configured error. */
- public static final int SSL_CONFIGURATION_ERR = COMMON_ERR_GROUP.registerErrorCode(5);
+ public static final int SSL_CONFIGURATION_ERR = COMMON_ERR_GROUP.registerErrorCode(4);
- /** Unknown error. */
- @Deprecated
- public static final int UNKNOWN_ERR = COMMON_ERR_GROUP.registerErrorCode(0xFFFF);
+ /**
+ * This error code represents an internal error caused by faulty logic or coding in the Ignite codebase.
+ * In general, this error code should be considered as a non-recoverable error
+ */
+ public static final int INTERNAL_ERR = COMMON_ERR_GROUP.registerErrorCode(0xFFFF);
Review Comment:
By the way, we already have INTERNAL_ERR in SQL_ERR_GROUP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2097: IGNITE-19533 Renamed UNKNOWN_ERR error code to INTERNAL_ERR. Removed UNEXPECTED_ERR error code.
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #2097:
URL: https://github.com/apache/ignite-3/pull/2097#discussion_r1204042232
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -27,24 +27,23 @@ public static class Common {
/** Unknown error group. */
public static final ErrorGroup COMMON_ERR_GROUP = ErrorGroup.newGroup("CMN", 1);
- /** Unexpected error. */
- public static final int UNEXPECTED_ERR = COMMON_ERR_GROUP.registerErrorCode(1);
-
/** Node stopping error. */
- public static final int NODE_STOPPING_ERR = COMMON_ERR_GROUP.registerErrorCode(2);
+ public static final int NODE_STOPPING_ERR = COMMON_ERR_GROUP.registerErrorCode(1);
/** Component not started error. */
- public static final int COMPONENT_NOT_STARTED_ERR = COMMON_ERR_GROUP.registerErrorCode(3);
+ public static final int COMPONENT_NOT_STARTED_ERR = COMMON_ERR_GROUP.registerErrorCode(2);
/** Illegal argument or argument in a wrong format has been passed. */
- public static final int ILLEGAL_ARGUMENT_ERR = COMMON_ERR_GROUP.registerErrorCode(4);
+ public static final int ILLEGAL_ARGUMENT_ERR = COMMON_ERR_GROUP.registerErrorCode(3);
/** SSL can not be configured error. */
- public static final int SSL_CONFIGURATION_ERR = COMMON_ERR_GROUP.registerErrorCode(5);
+ public static final int SSL_CONFIGURATION_ERR = COMMON_ERR_GROUP.registerErrorCode(4);
- /** Unknown error. */
- @Deprecated
- public static final int UNKNOWN_ERR = COMMON_ERR_GROUP.registerErrorCode(0xFFFF);
+ /**
+ * This error code represents an internal error caused by faulty logic or coding in the Ignite codebase.
+ * In general, this error code should be considered as a non-recoverable error
+ */
+ public static final int INTERNAL_ERR = COMMON_ERR_GROUP.registerErrorCode(0xFFFF);
Review Comment:
Changed all occurrences to Common.INTERNAL_ERR. The Sql.INTERNAL_ERR removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org