You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/10 14:47:45 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #15105: [FLINK-21606] Reject JobManager <-> TaskManager connection if JobManager is not responsible for job
tillrohrmann commented on a change in pull request #15105:
URL: https://github.com/apache/flink/pull/15105#discussion_r591583613
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/DefaultJobLeaderService.java
##########
@@ -470,6 +475,7 @@ protected void onRegistrationFailure(Throwable failure) {
return gateway.registerTaskManager(
taskManagerRpcAddress,
unresolvedTaskManagerLocation,
+ jobId,
Review comment:
The `fencingToken` is a concept of the underlying `RpcSystem` whereas the `JobID` is a concept of the "application layer". That's why it is not guaranteed that fencing tokens are different iff `JobIDs` are different. An example is the standalone mode where the fencing token is always `0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org