You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ga...@apache.org on 2023/07/11 08:23:42 UTC
[seatunnel] branch dev updated: [Feature][Connector-V2][cdc] Change the time zone to the default time zone (#5030)
This is an automated email from the ASF dual-hosted git repository.
gaojun2048 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 3cff923a7 [Feature][Connector-V2][cdc] Change the time zone to the default time zone (#5030)
3cff923a7 is described below
commit 3cff923a7954977ddea3b4b16fec50659e4a238f
Author: Carl-Zhou-CN <67...@users.noreply.github.com>
AuthorDate: Tue Jul 11 16:23:36 2023 +0800
[Feature][Connector-V2][cdc] Change the time zone to the default time zone (#5030)
---
docs/en/connector-v2/source/MySQL-CDC.md | 2 +-
.../seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java | 7 +++++--
.../cdc/debezium/row/SeaTunnelRowDebeziumDeserializeSchema.java | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/docs/en/connector-v2/source/MySQL-CDC.md b/docs/en/connector-v2/source/MySQL-CDC.md
index f26c1e60a..caeeca062 100644
--- a/docs/en/connector-v2/source/MySQL-CDC.md
+++ b/docs/en/connector-v2/source/MySQL-CDC.md
@@ -155,7 +155,7 @@ By default, a random number is generated between 5400 and 6400, though we recomm
### server-time-zone [String]
-The session time zone in database server.
+The session time zone in database server. If not set, then ZoneId.systemDefault() is used to determine the server time zone.
### connect.timeout.ms [long]
diff --git a/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java b/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java
index ea64cd3d2..715915c74 100644
--- a/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java
+++ b/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java
@@ -21,6 +21,7 @@ import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;
import org.apache.seatunnel.connectors.cdc.base.source.IncrementalSource;
+import java.time.ZoneId;
import java.util.List;
/** Configurations for {@link IncrementalSource} of JDBC data source. */
@@ -61,8 +62,10 @@ public class JdbcSourceOptions extends SourceOptions {
public static final Option<String> SERVER_TIME_ZONE =
Options.key("server-time-zone")
.stringType()
- .defaultValue("UTC")
- .withDescription("The session time zone in database server.");
+ .defaultValue(ZoneId.systemDefault().getId())
+ .withDescription(
+ "The session time zone in database server."
+ + "If not set, then ZoneId.systemDefault() is used to determine the server time zone");
public static final Option<String> SERVER_ID =
Options.key("server-id")
diff --git a/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/debezium/row/SeaTunnelRowDebeziumDeserializeSchema.java b/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/debezium/row/SeaTunnelRowDebeziumDeserializeSchema.java
index d9cdf2f50..2997fc78d 100644
--- a/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/debezium/row/SeaTunnelRowDebeziumDeserializeSchema.java
+++ b/seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/debezium/row/SeaTunnelRowDebeziumDeserializeSchema.java
@@ -211,7 +211,7 @@ public final class SeaTunnelRowDebeziumDeserializeSchema
private SeaTunnelDataType<SeaTunnelRow> resultTypeInfo;
private MetadataConverter[] metadataConverters = new MetadataConverter[0];
private ValueValidator validator = (rowData, rowKind) -> {};
- private ZoneId serverTimeZone = ZoneId.of("UTC");
+ private ZoneId serverTimeZone = ZoneId.systemDefault();
private DebeziumDeserializationConverterFactory userDefinedConverterFactory =
DebeziumDeserializationConverterFactory.DEFAULT;