You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/15 13:03:23 UTC
[GitHub] [arrow] tustvold opened a new pull request #10048: ARROW-12400: Re-enable tests in arrow::array::transform
tustvold opened a new pull request #10048:
URL: https://github.com/apache/arrow/pull/10048
These tests were all commented out in #9329. Given the PR made changes to the commented out code, I'm inclined to think this was an accidental omission? If not, happy for this to be closed :grinning:
FYI @jorgecarleitao
Signed-off-by: Raphael Taylor-Davies <r....@googlemail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10048: ARROW-12400: [Rust] Re-enable tests in arrow::array::transform
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10048:
URL: https://github.com/apache/arrow/pull/10048#issuecomment-820502267
@andygrove I assume we'd like to have it in the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10048: ARROW-12400: [Rust] Re-enable tests in arrow::array::transform
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10048:
URL: https://github.com/apache/arrow/pull/10048#issuecomment-820451245
https://issues.apache.org/jira/browse/ARROW-12400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #10048: ARROW-12400: [Rust] Re-enable tests in arrow::array::transform
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #10048:
URL: https://github.com/apache/arrow/pull/10048#issuecomment-820466492
# [Codecov](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10048](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d3f407) into [master](https://codecov.io/gh/apache/arrow/commit/26a5a049b46c6949eb99f09a41da56232f0564c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26a5a04) will **increase** coverage by `0.24%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24%
==========================================
Files 286 286
Lines 64213 64664 +451
==========================================
+ Hits 50538 51054 +516
+ Misses 13675 13610 -65
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `93.20% <100.00%> (+22.96%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.05% <0.00%> (+0.19%)` | :arrow_up: |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `93.58% <0.00%> (+0.34%)` | :arrow_up: |
| [rust/arrow/src/array/data.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZGF0YS5ycw==) | `78.37% <0.00%> (+1.50%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `89.86% <0.00%> (+3.80%)` | :arrow_up: |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <0.00%> (+12.12%)` | :arrow_up: |
| [rust/arrow/src/array/transform/primitive.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ByaW1pdGl2ZS5ycw==) | `100.00% <0.00%> (+28.57%)` | :arrow_up: |
| [rust/arrow/src/array/transform/structure.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3N0cnVjdHVyZS5ycw==) | `83.33% <0.00%> (+38.88%)` | :arrow_up: |
| [rust/arrow/src/array/transform/null.rs](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL251bGwucnM=) | `66.66% <0.00%> (+66.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/arrow/pull/10048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c394a20...3d3f407](https://codecov.io/gh/apache/arrow/pull/10048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #10048: ARROW-12400: [Rust] Re-enable tests in arrow::array::transform
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #10048:
URL: https://github.com/apache/arrow/pull/10048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10048: ARROW-12400: [Rust] Re-enable tests in arrow::array::transform
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10048:
URL: https://github.com/apache/arrow/pull/10048#issuecomment-820531623
Ok, thought that implementation was affected as well. I'm still waiting for other PRs so feel free to merge on green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #10048: ARROW-12400: [Rust] Re-enable tests in arrow::array::transform
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #10048:
URL: https://github.com/apache/arrow/pull/10048#issuecomment-820526110
> @andygrove I assume we'd like to have it in the release.
FWIW @kszucs I don't think this is something that we should hold the release for -- it does not have any change to the actual code, only the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org