You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2026/09/18 04:42:16 UTC
[PR] [incubator-kie-7105] RuleUnit DSL: Follow-up CEP operators (#7105) [incubator-kie]
tkobayas opened a new pull request, #7122:
URL: https://github.com/apache/incubator-kie/pull/7122
- Closes https://github.com/apache/incubator-kie/issues/7105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-7105] RuleUnit DSL: Follow-up CEP operators (#7105) [incubator-kie]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #7122:
URL: https://github.com/apache/incubator-kie/pull/7122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-7105] RuleUnit DSL: Follow-up CEP operators (#7105) [incubator-kie]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7122:
URL: https://github.com/apache/incubator-kie/pull/7122#discussion_r4043880092
##########
drools-ruleunits/drools-ruleunits-dsl/src/main/java/org/drools/ruleunits/dsl/patterns/Pattern2DefImpl.java:
##########
@@ -74,16 +74,171 @@ public <V> Pattern2DefImpl<A, B> filter(String fieldName, Function1<B, V> leftEx
return this;
}
+ @Override
+ public Pattern2DefImpl<A, B> after() {
+ return addTemporalConstraint(DSL.after());
+ }
+
+ @Override
+ public Pattern2DefImpl<A, B> after(long min, TimeUnit unit) {
+ return addTemporalConstraint(DSL.after(min, unit));
+ }
+
@Override
public Pattern2DefImpl<A, B> after(long min, long max, TimeUnit unit) {
return addTemporalConstraint(DSL.after(min, unit, max, unit));
}
+ @Override
+ public Pattern2DefImpl<A, B> before() {
+ return addTemporalConstraint(DSL.before());
+ }
+
+ @Override
+ public Pattern2DefImpl<A, B> before(long min, TimeUnit unit) {
+ return addTemporalConstraint(DSL.before(min, unit));
+ }
+
@Override
public Pattern2DefImpl<A, B> before(long min, long max, TimeUnit unit) {
return addTemporalConstraint(DSL.before(min, unit, max, unit));
}
+ @Override
+ public Pattern2DefImpl<A, B> coincides() {
+ return addTemporalConstraint(DSL.coincides());
Review Comment:
The new operators are only covered by matching scenarios. With the current company filters, those tests would also pass if an implementation failed to add any temporal constraint, and the deviation overloads for `meets`/`metby`/`starts`/`startedby`/`finishes`/`finishedby` are exercised only at zero deviation. Add non-matching and boundary scenarios so each relation and its range/deviation arguments are verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-7105] RuleUnit DSL: Follow-up CEP operators (#7105) [incubator-kie]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #7122:
URL: https://github.com/apache/incubator-kie/pull/7122#discussion_r4043974125
##########
drools-ruleunits/drools-ruleunits-dsl/src/main/java/org/drools/ruleunits/dsl/patterns/Pattern2DefImpl.java:
##########
@@ -74,16 +74,171 @@ public <V> Pattern2DefImpl<A, B> filter(String fieldName, Function1<B, V> leftEx
return this;
}
+ @Override
+ public Pattern2DefImpl<A, B> after() {
+ return addTemporalConstraint(DSL.after());
+ }
+
+ @Override
+ public Pattern2DefImpl<A, B> after(long min, TimeUnit unit) {
+ return addTemporalConstraint(DSL.after(min, unit));
+ }
+
@Override
public Pattern2DefImpl<A, B> after(long min, long max, TimeUnit unit) {
return addTemporalConstraint(DSL.after(min, unit, max, unit));
}
+ @Override
+ public Pattern2DefImpl<A, B> before() {
+ return addTemporalConstraint(DSL.before());
+ }
+
+ @Override
+ public Pattern2DefImpl<A, B> before(long min, TimeUnit unit) {
+ return addTemporalConstraint(DSL.before(min, unit));
+ }
+
@Override
public Pattern2DefImpl<A, B> before(long min, long max, TimeUnit unit) {
return addTemporalConstraint(DSL.before(min, unit, max, unit));
}
+ @Override
+ public Pattern2DefImpl<A, B> coincides() {
+ return addTemporalConstraint(DSL.coincides());
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org