You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/03/15 12:31:45 UTC
Review Request 66086: ATLAS-2484 : UI - Need validation for Start
Date and End Date while applying validity period
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66086/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2484
https://issues.apache.org/jira/browse/ATLAS-2484
Repository: atlas
Description
-------
While assigning Tags to Entity, If Apply Validity Period is checked then Start Date should not be greater then End Date and Time Zone should not accept empty values.
Diffs
-----
dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html dbf7d66
dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html e7e1289
dashboardv2/public/js/views/tag/AddTagModalView.js 9d60e08
dashboardv2/public/js/views/tag/AddTimezoneItemView.js 015bb51
Diff: https://reviews.apache.org/r/66086/diff/1/
Testing
-------
Done one rouond of sanity testing.
Thanks,
pratik pandey
Re: Review Request 66086: ATLAS-2484 : UI - Need validation for Start
Date and End Date while applying validity period
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66086/#review199320
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On March 15, 2018, 12:31 p.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66086/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 12:31 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2484
> https://issues.apache.org/jira/browse/ATLAS-2484
>
>
> Repository: atlas
>
>
> Description
> -------
>
> While assigning Tags to Entity, If Apply Validity Period is checked then Start Date should not be greater then End Date and Time Zone should not accept empty values.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html dbf7d66
> dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html e7e1289
> dashboardv2/public/js/views/tag/AddTagModalView.js 9d60e08
> dashboardv2/public/js/views/tag/AddTimezoneItemView.js 015bb51
>
>
> Diff: https://reviews.apache.org/r/66086/diff/1/
>
>
> Testing
> -------
>
> Done one rouond of sanity testing.
>
>
> Thanks,
>
> pratik pandey
>
>