You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/02 16:07:59 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8311: ARROW-10008: [C++][Dataset] Fix filtering/row group statistics of dict columns

jorisvandenbossche commented on a change in pull request #8311:
URL: https://github.com/apache/arrow/pull/8311#discussion_r498913314



##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -171,6 +170,15 @@ static std::shared_ptr<StructScalar> ColumnChunkStatisticsAsStructScalar(
     return nullptr;
   }
 
+  auto maybe_min = min->CastTo(field->type());
+  auto maybe_max = max->CastTo(field->type());

Review comment:
       Does this change behaviour? For a dictionary with string values, is field->type() string or dictionary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org