You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by susanxhuynh <gi...@git.apache.org> on 2017/10/04 11:38:41 UTC
[GitHub] spark pull request #19428: [SPARK-22131][MESOS] Mesos driver secrets
GitHub user susanxhuynh opened a pull request:
https://github.com/apache/spark/pull/19428
[SPARK-22131][MESOS] Mesos driver secrets
## What changes were proposed in this pull request?
The driver launches executors that have access to env or file-based secrets.
Most of the changes are a refactor of the `dispatcher` secrets support - placing it in a common place that can be used by both the dispatcher and drivers. The same goes for the unit tests.
## How was this patch tested?
Unit tests.
Tested in DC/OS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mesosphere/spark sh-mesos-driver-secret
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19428
----
commit 4b7ae0a8e802f8ef6a159f3ce95b3203352b548f
Author: Susan X. Huynh <xh...@mesosphere.com>
Date: 2017-10-04T11:30:31Z
[SPARK-22131] Mesos driver secrets. The driver launches executors that have access to env or file-based secrets.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19428: [SPARK-22131][MESOS] Mesos driver secrets
Posted by susanxhuynh <gi...@git.apache.org>.
Github user susanxhuynh closed the pull request at:
https://github.com/apache/spark/pull/19428
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19428: [SPARK-22131][MESOS] Mesos driver secrets
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19428
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82449/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19428: [SPARK-22131][MESOS] Mesos driver secrets
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19428
**[Test build #82449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82449/testReport)** for PR 19428 at commit [`dcbfc4a`](https://github.com/apache/spark/commit/dcbfc4a94b63130d1944dc423cad961f83e4a463).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19428: [SPARK-22131][MESOS] Mesos driver secrets
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19428
**[Test build #82449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82449/testReport)** for PR 19428 at commit [`dcbfc4a`](https://github.com/apache/spark/commit/dcbfc4a94b63130d1944dc423cad961f83e4a463).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19428: [SPARK-22131][MESOS] Mesos driver secrets
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19428
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org