You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:58:06 UTC
[GitHub] [airflow] swecooo opened a new pull request #9019: Add script_args for S3FileTransformOperator
swecooo opened a new pull request #9019:
URL: https://github.com/apache/airflow/pull/9019
Sometimes there is a need to pass additional arguments to the `S3FileTransformOperator` script.
This PR introduces the possibility to provide arbitrary `str` arguments that will be appended to the command:
```bash
script f_source f_dest arg1 arg2 #...
```
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #9019: Add script_args for S3FileTransformOperator
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #9019:
URL: https://github.com/apache/airflow/pull/9019#discussion_r430561468
##########
File path: airflow/providers/amazon/aws/operators/s3_file_transform.py
##########
@@ -16,10 +16,12 @@
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=R0913
Review comment:
It would be better if you could add it to the actual place where it occurs - probably line 88 or 100 `# pylint: disable=too-many-arguments`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9019: Add script_args for S3FileTransformOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9019:
URL: https://github.com/apache/airflow/pull/9019#issuecomment-634004765
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] swecooo commented on pull request #9019: Add script_args for S3FileTransformOperator
Posted by GitBox <gi...@apache.org>.
swecooo commented on pull request #9019:
URL: https://github.com/apache/airflow/pull/9019#issuecomment-634493060
Thank you for the review @feluelle, the comment should now be acknowledged. The only problem is now the failing build but the same error occurs on `master`.
If it's OK, feel free to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] swecooo edited a comment on pull request #9019: Add script_args for S3FileTransformOperator
Posted by GitBox <gi...@apache.org>.
swecooo edited a comment on pull request #9019:
URL: https://github.com/apache/airflow/pull/9019#issuecomment-634493060
Thank you for the review @feluelle, the comment should now be acknowledged. The only remaining problem is the failing build but the same error occurs on `master`.
If it's OK, feel free to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org