You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mike Fagan <mf...@tde.com> on 2017/04/03 20:08:35 UTC

Re: Review Request 56290: HIVE-15795: Add Accumulo Index Table Support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56290/
-----------------------------------------------------------

(Updated April 3, 2017, 8:08 p.m.)


Review request for hive and Josh Elser.


Changes
-------

added q.test


Repository: hive-git


Description
-------

HIVE-15795: Add Accumulo Index Table Support


Diffs (updated)
-----

  accumulo-handler/pom.xml d22a54c 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexLexicoder.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScanner.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScannerException.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloStorageHandler.java cdbc7f2 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexDefinition.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexedOutputFormat.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/HiveAccumuloTableOutputFormat.java 3ae5431 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/IndexOutputConfigurator.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/package-info.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java a7ec7c5 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java 21392d1 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/PrimitiveComparisonFilter.java 17d5529 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloIndexParameters.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloSerDeParameters.java 09c5f24 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/package-info.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloDefaultIndexScanner.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexLexicoder.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexParameters.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloStorageHandler.java 0aaa782 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java 88e4530 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java 339da07 
  accumulo-handler/src/test/queries/positive/accumulo_queries.q 279b661 


Diff: https://reviews.apache.org/r/56290/diff/5/

Changes: https://reviews.apache.org/r/56290/diff/4-5/


Testing
-------


Thanks,

Mike Fagan

Re: Review Request 56290: HIVE-15795: Add Accumulo Index Table Support

Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56290/#review170973
-----------------------------------------------------------


Ship it!




Ship It!

- Josh Elser


On April 3, 2017, 8:12 p.m., Mike Fagan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56290/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 8:12 p.m.)
> 
> 
> Review request for hive and Josh Elser.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15795: Add Accumulo Index Table Support
> 
> 
> Diffs
> -----
> 
>   accumulo-handler/pom.xml d22a54c 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexLexicoder.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScanner.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScannerException.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloStorageHandler.java cdbc7f2 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexDefinition.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexedOutputFormat.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/HiveAccumuloTableOutputFormat.java 3ae5431 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/IndexOutputConfigurator.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/package-info.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java a7ec7c5 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java 21392d1 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/PrimitiveComparisonFilter.java 17d5529 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloIndexParameters.java PRE-CREATION 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloSerDeParameters.java 09c5f24 
>   accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/package-info.java PRE-CREATION 
>   accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloDefaultIndexScanner.java PRE-CREATION 
>   accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexLexicoder.java PRE-CREATION 
>   accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexParameters.java PRE-CREATION 
>   accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloStorageHandler.java 0aaa782 
>   accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java 88e4530 
>   accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java 339da07 
>   accumulo-handler/src/test/queries/positive/accumulo_index.q PRE-CREATION 
>   accumulo-handler/src/test/results/positive/accumulo_index.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56290/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Fagan
> 
>

Re: Review Request 56290: HIVE-15795: Add Accumulo Index Table Support

Posted by Mike Fagan <mf...@tde.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56290/
-----------------------------------------------------------

(Updated April 3, 2017, 8:12 p.m.)


Review request for hive and Josh Elser.


Changes
-------

fixed query patch


Repository: hive-git


Description
-------

HIVE-15795: Add Accumulo Index Table Support


Diffs (updated)
-----

  accumulo-handler/pom.xml d22a54c 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexLexicoder.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScanner.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScannerException.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloStorageHandler.java cdbc7f2 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexDefinition.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/AccumuloIndexedOutputFormat.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/HiveAccumuloTableOutputFormat.java 3ae5431 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/IndexOutputConfigurator.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/package-info.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java a7ec7c5 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java 21392d1 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/PrimitiveComparisonFilter.java 17d5529 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloIndexParameters.java PRE-CREATION 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloSerDeParameters.java 09c5f24 
  accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/package-info.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloDefaultIndexScanner.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexLexicoder.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexParameters.java PRE-CREATION 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloStorageHandler.java 0aaa782 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java 88e4530 
  accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java 339da07 
  accumulo-handler/src/test/queries/positive/accumulo_index.q PRE-CREATION 
  accumulo-handler/src/test/results/positive/accumulo_index.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/56290/diff/6/

Changes: https://reviews.apache.org/r/56290/diff/5-6/


Testing
-------


Thanks,

Mike Fagan