You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/08/22 16:40:41 UTC

[GitHub] tinkerpop pull request #387: TINKERPOP-1386 Bumped to Netty 4.0.40.final

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/387

    TINKERPOP-1386 Bumped to Netty 4.0.40.final

    https://issues.apache.org/jira/browse/TINKERPOP-1386
    
    Hand to modify the WebSocketClient slightly as it was taking advantage of a bug in netty that was fixed at 4.0.35.final: https://github.com/netty/netty/commit/2e6544fc0e2581f96652be02d86e777e8e0493bc#diff-e4e87d5bebf757b077c19618841f41a6R56
    
    All good with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1386

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
    
----
commit 49dcb61c152f2bb59c8cc5ae21742ae087e22e70
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-08-22T16:37:22Z

    Bumped to netty 4.0.40.final
    
    Hand to modify the WebSocketClient slightly as it was taking advantage of a bug in netty that was fixed at 4.0.35.final: https://github.com/netty/netty/commit/2e6544fc0e2581f96652be02d86e777e8e0493bc#diff-e4e87d5bebf757b077c19618841f41a6R56

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #387: TINKERPOP-1386 Bumped to Netty 4.0.40.final

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/387


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #387: TINKERPOP-1386 Bumped to Netty 4.0.40.final

Posted by twilmes <gi...@git.apache.org>.

Github user twilmes commented on the issue:

    https://github.com/apache/tinkerpop/pull/387
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #387: TINKERPOP-1386 Bumped to Netty 4.0.40.final

Posted by PommeVerte <gi...@git.apache.org>.

Github user PommeVerte commented on the issue:

    https://github.com/apache/tinkerpop/pull/387
  
    Straightforward enough and tests pass so VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---