You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/11/07 19:54:54 UTC

[kudu-CR] [python] - Expand KuduError capabilities

Jean-Daniel Cryans has posted comments on this change.

Change subject: [python] - Expand KuduError capabilities
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 212:         self.assertTrue(error.was_possibly_successful())
Maybe add a note that this is passing because we always return true at the moment?


-- 
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes