You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Sanjay Dahiya (JIRA)" <ji...@apache.org> on 2006/11/29 12:59:22 UTC
[jira] Created: (HADOOP-761) Unit tests should not cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Unit tests should not cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
-------------------------------------------------------------------------------------------------------------------------------
Key: HADOOP-761
URL: http://issues.apache.org/jira/browse/HADOOP-761
Project: Hadoop
Issue Type: Bug
Components: test
Reporter: Sanjay Dahiya
Priority: Minor
TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-761:
-------------------------------
Fix Version/s: 0.12.0
Affects Version/s: 0.11.0
Status: Patch Available (was: Open)
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: https://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Affects Versions: 0.11.0
> Reporter: Sanjay Dahiya
> Assigned To: Nigel Daley
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: HADOOP-761.patch
>
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-761:
-------------------------------
Attachment: HADOOP-761.patch
This patches fixes TestMiniMRLocalFS, all the streaming tests, and the libhdfs test. Once this patch is applied, no test should write files to /tmp (except for those temporarily created by Jetty).
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: https://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Affects Versions: 0.11.0
> Reporter: Sanjay Dahiya
> Assigned To: Nigel Daley
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: HADOOP-761.patch
>
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "eric baldeschwieler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-761?page=comments#action_12454548 ]
eric baldeschwieler commented on HADOOP-761:
--------------------------------------------
Using /tmp is simply not a good idea. It leaves you vulnerable to various of system configuration differences, of which there are millions out there. We should create temp files in the test's working directory.
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: http://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Reporter: Sanjay Dahiya
> Priority: Minor
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471779 ]
Hadoop QA commented on HADOOP-761:
----------------------------------
+1, because http://issues.apache.org/jira/secure/attachment/12350777/HADOOP-761.patch applied and successfully tested against trunk revision r505362.
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: https://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Affects Versions: 0.11.0
> Reporter: Sanjay Dahiya
> Assigned To: Nigel Daley
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: HADOOP-761.patch
>
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-761:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Nigel!
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: https://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Affects Versions: 0.11.0
> Reporter: Sanjay Dahiya
> Assigned To: Nigel Daley
> Priority: Minor
> Fix For: 0.12.0
>
> Attachments: HADOOP-761.patch
>
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "eric baldeschwieler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-761?page=comments#action_12454549 ]
eric baldeschwieler commented on HADOOP-761:
--------------------------------------------
We should start a unit test authors document and add this to it!
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: http://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Reporter: Sanjay Dahiya
> Priority: Minor
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471549 ]
Nigel Daley commented on HADOOP-761:
------------------------------------
Streaming tests and libhdfs tests also use /tmp.
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: https://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Reporter: Sanjay Dahiya
> Assigned To: Nigel Daley
> Priority: Minor
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-761) Unit tests should cleanup created
files in /tmp. It causes tests to fail if more than one users run tests on
same machine.
Posted by "Sanjay Dahiya (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HADOOP-761?page=all ]
Sanjay Dahiya updated HADOOP-761:
---------------------------------
Summary: Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine. (was: Unit tests should not cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.)
> Unit tests should cleanup created files in /tmp. It causes tests to fail if more than one users run tests on same machine.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-761
> URL: http://issues.apache.org/jira/browse/HADOOP-761
> Project: Hadoop
> Issue Type: Bug
> Components: test
> Reporter: Sanjay Dahiya
> Priority: Minor
>
> TestMiniMRLocalFS test cases creates /tmp/wc/input/, which is not cleaned up, any other user running test on same machine simultaneously or later will see test failures.
> It should either use a temp directory in the build/test or use java's File.createTempFile method for temporary data and then clean it up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira