You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/25 19:48:30 UTC
[kudu-CR] java: fix remainder of error-prone issues
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10202
to review the following change.
Change subject: java: fix remainder of error-prone issues
......................................................................
java: fix remainder of error-prone issues
- Suppress a few false positives where we are doing something sketchy
but know it to be OK
- Fix two cases where a class member shadowed a member of a superclass
- Avoid StringBuffer in timestampToString. StringBuffer is synchronized,
so it is probably more efficient to use plain String concatenation
instead.[1]
- Avoid reference-equality checks in Status.fromMasterErrorPB and
Status.fromTabletServerErrorPB. Based on the call sites I believe
these checks would never have fired, because we only call these
methods in cases where we know there to have been an actual error.
- Fix construction of the Flume KuduOperationProducer implementation to
properly throw exceptions by using
clazz.getDeclaredConstructor().newInstance() instead of
clazz.newInstance()[2]
[1] https://github.com/google/error-prone/blob/master/docs/bugpattern/JdkObsolete.md
[2] https://github.com/google/error-prone/blob/master/docs/bugpattern/ClassNewInstance.md
Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
11 files changed, 27 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/10202/1
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG@15
PS1, Line 15: so it is probably more efficient to use plain String concatenation
: instead.[1]
> There's no version of DateFormatter which takes a StringBuilder. So, I had
Makes sense, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:18:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.
Change subject: java: fix remainder of error-prone issues
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 17:43:00 +0000
Gerrit-HasComments: No
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 22:21:15 +0000
Gerrit-HasComments: No
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG@15
PS1, Line 15: so it is probably more efficient to use plain String concatenation
: instead.[1]
Curious why you didn't use StringBuilder here; that's the recommendation in [1].
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 25 Apr 2018 20:04:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG@15
PS1, Line 15: so it is probably more efficient to use plain String concatenation
: instead.[1]
> Curious why you didn't use StringBuilder here; that's the recommendation in
There's no version of DateFormatter which takes a StringBuilder. So, I had to use the version which returns a String, at which point there isn't really any advantage of creating a stringbuilder just to concat two strings.
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:04:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
java: fix remainder of error-prone issues
- Suppress a few false positives where we are doing something sketchy
but know it to be OK
- Fix two cases where a class member shadowed a member of a superclass
- Avoid StringBuffer in timestampToString. StringBuffer is synchronized,
so it is probably more efficient to use plain String concatenation
instead.[1]
- Avoid reference-equality checks in Status.fromMasterErrorPB and
Status.fromTabletServerErrorPB. Based on the call sites I believe
these checks would never have fired, because we only call these
methods in cases where we know there to have been an actual error.
- Fix construction of the Flume KuduOperationProducer implementation to
properly throw exceptions by using
clazz.getDeclaredConstructor().newInstance() instead of
clazz.newInstance()[2]
[1] https://github.com/google/error-prone/blob/master/docs/bugpattern/JdkObsolete.md
[2] https://github.com/google/error-prone/blob/master/docs/bugpattern/ClassNewInstance.md
Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Reviewed-on: http://gerrit.cloudera.org:8080/10202
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
11 files changed, 27 insertions(+), 30 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] java: fix remainder of error-prone issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 14:46:17 +0000
Gerrit-HasComments: No