[GitHub] [inlong] healchow commented on a diff in pull request #6310: [INLONG-6309][Docker][Audit] Add configuration for audit driver and url

[GitBox <gi...@apache.org>]

healchow commented on code in PR #6310:
URL: https://github.com/apache/inlong/pull/6310#discussion_r1007565230


##########
inlong-audit/audit-docker/audit-docker.sh:
##########
@@ -43,11 +43,10 @@ if [ "${MQ_TYPE}" = "tubemq" ]; then
 fi
 
 # replace the configuration for audit store
-if [ -n "${STORE_MODE}" ]; then
-  sed -i "s/audit.config.store.mode=.*$/audit.config.store.mode=${STORE_MODE}/g" "${store_conf_file}"
-fi
+sed -i "s/audit.config.store.mode=.*$/audit.config.store.mode=${STORE_MODE}/g" "${store_conf_file}"
+sed -i "s/spring.datasource.druid.driver-class-name=.*$/spring.datasource.druid.driver-class-name=com.${DRIVER_CLASS_NAME}.cj.jdbc.Driver/g" "${store_conf_file}"
 # DB
-sed -i "s/127.0.0.1:3306\/apache_inlong_audit/${JDBC_URL}\/${AUDIT_DBNAME}/g" "${store_conf_file}"
+sed -i "s/spring.datasource.druid.url=.*$/spring.datasource.druid.url=jdbc:${STORE_MODE}:\/\/${JDBC_URL}\/${AUDIT_DBNAME}/g" "${store_conf_file}"

Review Comment:
   Suggest changing all the URL info at the same time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org