You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by bu...@apache.org on 2005/05/27 05:59:44 UTC

DO NOT REPLY [Bug 35096] New: - [Digester][PATCH] Cannot add multiple CallMethodRules for the same pattern

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35096>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35096

           Summary: [Digester][PATCH] Cannot add multiple CallMethodRules
                    for the same pattern
           Product: Commons
           Version: 1.6 Final
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Digester
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: akolkar@us.ibm.com


ISSUE:
The issue is summarized here, URI might get fragmented, copy with care [ 
http://marc.theaimsgroup.com/?l=jakarta-commons-user&m=111706440425278&w=2 ]

PROPOSED SOLUTION:
Instead of storing an object array as an element of the parameters stack in 
Digester (which is utilized by CallMethodRule and CallParamRule rules), store 
a list of object arrays.

Add an index property to CallMethodRule corresponding to its document order 
(within CallMethodRules for the same pattern), and use that to access the 
appropriate element within the list at the top of the parameters stack.

The same index provides users the ability to associate a CallParamRule with 
the appropriate CallMethodRule.

Patch is attached in next post. Javadoc needs to be brushed up, I can do that 
depending on interest in the patch. Patch also contains updated call method 
rule test cases (one change in the 'testTwoCalls' test case), all 15 now pass. 

There is full backward compatibility. Comments/suggestions welcome.

-Rahul

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org