You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/09/08 01:55:34 UTC
[PR] upgrade Bootstrap v5.3.8 [datafusion-site]
kevinjqliu opened a new pull request, #105:
URL: https://github.com/apache/datafusion-site/pull/105
Running locally, i noticed this console error:
<img width="1392" height="179" alt="Screenshot 2025-09-07 at 6 51 55 PM" src="https://github.com/user-attachments/assets/b0ee0164-056e-4c76-98b1-11bae95b1ea8" />
Upgrading bootstrap fixed the error.
Taken from bootstrap repo, tag v5.3.8:
- https://github.com/twbs/bootstrap/blob/v5.3.8/dist/js/bootstrap.bundle.min.js
- https://github.com/twbs/bootstrap/blob/v5.3.8/dist/js/bootstrap.bundle.min.js.map
Heres what I ran:
```
curl -L https://raw.githubusercontent.com/twbs/bootstrap/refs/tags/v5.3.8/dist/js/bootstrap.bundle.min.js -o content/js/bootstrap.bundle.min.js
curl -L https://raw.githubusercontent.com/twbs/bootstrap/refs/tags/v5.3.8/dist/js/bootstrap.bundle.min.js.map -o content/js/bootstrap.bundle.min.js.map
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] upgrade Bootstrap v5.3.8 [datafusion-site]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #105:
URL: https://github.com/apache/datafusion-site/pull/105#issuecomment-4070033455
This also fixes #117! The bootstrap error caused the hamburger menu to not function correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] upgrade Bootstrap v5.3.8 [datafusion-site]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #105:
URL: https://github.com/apache/datafusion-site/pull/105#issuecomment-4069921317
Updated `bootstrap.min.css`, thanks!
These are the only 3 bootstrap files in the repo:
<img width="708" height="252" alt="Screenshot 2026-03-16 at 11 59 47 AM" src="https://github.com/user-attachments/assets/1ae52ffd-a0cc-4d61-b79a-c7fa38fbad54" />
I found the instructions on upgrading bootstrap
https://github.com/apache/datafusion-site/blob/8c89c73e93ee86314146402f102f25124fb65b20/README.md?plain=1#L63-L73
I tested this locally (had to hard-refresh browser to clear cache). The previous error disappears.
Feel free to run the curl commands locally to check that the files are not modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] upgrade Bootstrap v5.3.8 [datafusion-site]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #105:
URL: https://github.com/apache/datafusion-site/pull/105#issuecomment-4070236135
I also verified the error is gone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] upgrade Bootstrap v5.3.8 [datafusion-site]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #105:
URL: https://github.com/apache/datafusion-site/pull/105#issuecomment-3281187360
Thanks @kevinjqliu
I don't know too much about this process, but it seems like the release artifact `bootstrap-5.3.8-dist.zip` from https://github.com/twbs/bootstrap/releases/tag/v5.3.8
Has several more files than this. Should include all of them?
Also, do we need to update the corresponding css as well?
```
andrewlamb@Andrews-MacBook-Pro-3:~/Downloads$ unzip bootstrap-5.3.8-dist.zip
Archive: bootstrap-5.3.8-dist.zip
creating: /Users/andrewlamb/Downloads/bootstrap-5.3.8-dist
creating: /Users/andrewlamb/Downloads/bootstrap-5.3.8-dist/css
inflating: bootstrap-5.3.8-dist/css/bootstrap.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.rtl.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.rtl.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.rtl.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap.rtl.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap.rtl.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.rtl.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.rtl.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap.rtl.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.rtl.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.rtl.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap.rtl.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.rtl.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.rtl.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-utilities.rtl.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.rtl.min.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.min.css.map
inflating: bootstrap-5.3.8-dist/css/bootstrap-grid.rtl.css
inflating: bootstrap-5.3.8-dist/css/bootstrap-reboot.css.map
creating: /Users/andrewlamb/Downloads/bootstrap-5.3.8-dist/js
inflating: bootstrap-5.3.8-dist/js/bootstrap.esm.min.js
inflating: bootstrap-5.3.8-dist/js/bootstrap.esm.js
inflating: bootstrap-5.3.8-dist/js/bootstrap.bundle.js
inflating: bootstrap-5.3.8-dist/js/bootstrap.bundle.min.js.map
inflating: bootstrap-5.3.8-dist/js/bootstrap.bundle.js.map
inflating: bootstrap-5.3.8-dist/js/bootstrap.esm.js.map
inflating: bootstrap-5.3.8-dist/js/bootstrap.js
inflating: bootstrap-5.3.8-dist/js/bootstrap.bundle.min.js
inflating: bootstrap-5.3.8-dist/js/bootstrap.min.js
inflating: bootstrap-5.3.8-dist/js/bootstrap.esm.min.js.map
inflating: bootstrap-5.3.8-dist/js/bootstrap.js.map
inflating: bootstrap-5.3.8-dist/js/bootstrap.min.js.map
```
Do you think we should install
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] upgrade Bootstrap v5.3.8 [datafusion-site]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #105:
URL: https://github.com/apache/datafusion-site/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org