You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/11/13 08:47:25 UTC

[GitHub] incubator-zeppelin pull request: Deactivate IE scrollbar on page

GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/425

    Deactivate IE scrollbar on page

    The page scrollbar of IE (at least 10) is covering the content of the page
    <img width="177" alt="screen shot 2015-11-13 at 4 39 29 pm" src="https://cloud.githubusercontent.com/assets/710411/11141176/25106cda-8a26-11e5-97b3-0d292d4bd6fe.png">
    
    This PR is removing that style for a traditional scrollbar
    <img width="181" alt="screen shot 2015-11-13 at 4 45 00 pm" src="https://cloud.githubusercontent.com/assets/710411/11141183/323fbd48-8a26-11e5-8056-b56e712e7d65.png">


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin fix/IEWindowScrollBar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #425
    
----
commit ff31829813b291111defb8b25ac9a018feae1655
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-11-13T07:45:48Z

    Deactivate IE scrollbar on page

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Deactivate IE scrollbar on page

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/425#issuecomment-156576556
  
    looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Deactivate IE scrollbar on page

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/425#issuecomment-156596013
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Deactivate IE scrollbar on page

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---