You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/01/27 21:55:06 UTC
Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
Bugs: AURORA-30
https://issues.apache.org/jira/browse/AURORA-30
Repository: aurora
Description
-------
Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
Diffs
-----
3rdparty/python/BUILD PRE-CREATION
aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
Diff: https://reviews.apache.org/r/17419/diff/
Testing
-------
Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
Thanks,
Jake Farrell
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Brian Wickman <wi...@twopensource.com>.
> On Jan. 27, 2014, 10:12 p.m., Brian Wickman wrote:
> > 3rdparty/python/BUILD, line 1
> > <https://reviews.apache.org/r/17419/diff/1/?file=451783#file451783line1>
> >
> > I don't see any good reason to use make_dep over straight up python_requirements since there's nothing preventing us from doing python_requirement oneliners:
> >
> > python_requirement('argparse==1.2.1')
> > python_requirement('bottle==0.11.6')
> > ...
> >
> > they will correctly resolve as 3rdparty/python:argparse, 3rdparty/python:bottle, etc.
> >
>
> Kevin Sweeney wrote:
> You learn something new every day! Is that feature documented anywhere?
it's always been that way. i'm not sure if it's explicitly documented anywhere, but in the PythonRequirement constructor:
self._name = name or self._requirement.project_name
where self._requirement is the :class:`pkg_resources.Requirement` parsed from the requirement string.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32893
-----------------------------------------------------------
On Jan. 27, 2014, 8:54 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17419/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 8:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-30
> https://issues.apache.org/jira/browse/AURORA-30
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD PRE-CREATION
> aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
> aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
> aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
> aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
> aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
> aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
> aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
> aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
> aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
> aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
> aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
> aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
> aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
> aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
> aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
> aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
> aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
> aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
> aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
> aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
> aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
> aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
> aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
> aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
> aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
> aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
> aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
> aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
> aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
> aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
> aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
> aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
> src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
> src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
> src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
> src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
> src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
> src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
> src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
> src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
> src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
> src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
> src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
> src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
> src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
> src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
> src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
> src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
> src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
> src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
> src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
> src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
> src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
> src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
> src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
> src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
> src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
> src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
> src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
> src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
> src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
> src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
> src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
> src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
> src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
> src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
> src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
> src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
> src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
> src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
>
> Diff: https://reviews.apache.org/r/17419/diff/
>
>
> Testing
> -------
>
> Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Kevin Sweeney <ke...@apache.org>.
> On Jan. 27, 2014, 2:12 p.m., Brian Wickman wrote:
> > 3rdparty/python/BUILD, line 1
> > <https://reviews.apache.org/r/17419/diff/1/?file=451783#file451783line1>
> >
> > I don't see any good reason to use make_dep over straight up python_requirements since there's nothing preventing us from doing python_requirement oneliners:
> >
> > python_requirement('argparse==1.2.1')
> > python_requirement('bottle==0.11.6')
> > ...
> >
> > they will correctly resolve as 3rdparty/python:argparse, 3rdparty/python:bottle, etc.
> >
You learn something new every day! Is that feature documented anywhere?
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32893
-----------------------------------------------------------
On Jan. 27, 2014, 12:54 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17419/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 12:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-30
> https://issues.apache.org/jira/browse/AURORA-30
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD PRE-CREATION
> aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
> aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
> aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
> aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
> aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
> aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
> aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
> aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
> aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
> aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
> aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
> aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
> aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
> aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
> aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
> aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
> aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
> aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
> aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
> aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
> aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
> aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
> aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
> aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
> aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
> aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
> aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
> aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
> aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
> aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
> aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
> aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
> src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
> src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
> src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
> src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
> src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
> src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
> src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
> src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
> src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
> src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
> src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
> src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
> src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
> src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
> src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
> src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
> src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
> src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
> src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
> src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
> src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
> src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
> src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
> src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
> src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
> src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
> src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
> src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
> src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
> src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
> src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
> src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
> src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
> src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
> src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
> src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
> src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
> src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
>
> Diff: https://reviews.apache.org/r/17419/diff/
>
>
> Testing
> -------
>
> Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32893
-----------------------------------------------------------
3rdparty/python/BUILD
<https://reviews.apache.org/r/17419/#comment61895>
I don't see any good reason to use make_dep over straight up python_requirements since there's nothing preventing us from doing python_requirement oneliners:
python_requirement('argparse==1.2.1')
python_requirement('bottle==0.11.6')
...
they will correctly resolve as 3rdparty/python:argparse, 3rdparty/python:bottle, etc.
- Brian Wickman
On Jan. 27, 2014, 8:54 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17419/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 8:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-30
> https://issues.apache.org/jira/browse/AURORA-30
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD PRE-CREATION
> aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
> aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
> aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
> aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
> aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
> aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
> aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
> aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
> aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
> aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
> aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
> aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
> aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
> aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
> aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
> aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
> aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
> aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
> aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
> aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
> aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
> aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
> aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
> aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
> aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
> aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
> aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
> aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
> aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
> aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
> aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
> aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
> src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
> src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
> src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
> src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
> src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
> src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
> src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
> src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
> src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
> src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
> src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
> src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
> src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
> src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
> src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
> src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
> src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
> src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
> src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
> src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
> src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
> src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
> src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
> src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
> src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
> src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
> src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
> src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
> src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
> src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
> src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
> src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
> src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
> src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
> src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
> src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
> src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
> src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
>
> Diff: https://reviews.apache.org/r/17419/diff/
>
>
> Testing
> -------
>
> Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32938
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2014, 12:19 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17419/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-30
> https://issues.apache.org/jira/browse/AURORA-30
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD PRE-CREATION
> aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
> aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
> aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
> aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
> aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
> aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
> aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
> aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
> aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
> aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
> aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
> aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
> aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
> aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
> aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
> aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
> aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
> aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
> aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
> aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
> aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
> aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
> aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
> aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
> aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
> aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
> aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
> aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
> aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
> aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
> aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
> aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
> src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
> src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
> src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
> src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
> src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
> src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
> src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
> src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
> src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
> src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
> src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
> src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
> src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
> src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
> src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
> src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
> src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
> src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
> src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
> src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
> src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
> src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
> src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
> src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
> src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
> src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
> src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
> src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
> src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
> src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
> src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
> src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
> src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
> src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
> src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
> src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
> src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
> src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
>
> Diff: https://reviews.apache.org/r/17419/diff/
>
>
> Testing
> -------
>
> Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32937
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2014, 12:19 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17419/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-30
> https://issues.apache.org/jira/browse/AURORA-30
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD PRE-CREATION
> aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
> aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
> aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
> aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
> aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
> aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
> aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
> aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
> aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
> aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
> aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
> aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
> aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
> aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
> aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
> aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
> aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
> aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
> aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
> aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
> aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
> aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
> aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
> aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
> aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
> aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
> aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
> aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
> aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
> aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
> aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
> aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
> src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
> src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
> src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
> src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
> src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
> src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
> src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
> src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
> src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
> src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
> src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
> src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
> src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
> src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
> src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
> src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
> src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
> src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
> src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
> src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
> src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
> src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
> src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
> src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
> src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
> src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
> src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
> src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
> src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
> src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
> src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
> src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
> src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
> src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
> src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
> src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
> src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
> src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
>
> Diff: https://reviews.apache.org/r/17419/diff/
>
>
> Testing
> -------
>
> Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32923
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 27, 2014, 4:19 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17419/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 4:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-30
> https://issues.apache.org/jira/browse/AURORA-30
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD PRE-CREATION
> aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
> aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
> aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
> aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
> aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
> aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
> aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
> aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
> aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
> aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
> aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
> aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
> aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
> aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
> aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
> aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
> aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
> aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
> aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
> aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
> aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
> aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
> aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
> aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
> aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
> aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
> aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
> aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
> aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
> aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
> aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
> aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
> src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
> src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
> src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
> src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
> src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
> src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
> src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
> src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
> src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
> src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
> src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
> src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
> src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
> src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
> src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
> src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
> src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
> src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
> src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
> src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
> src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
> src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
> src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
> src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
> src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
> src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
> src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
> src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
> src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
> src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
> src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
> src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
> src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
> src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
> src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
> src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
> src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
> src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
>
> Diff: https://reviews.apache.org/r/17419/diff/
>
>
> Testing
> -------
>
> Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python
deps
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 12:19 a.m.)
Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
Changes
-------
Updated patch based on feedback
Bugs: AURORA-30
https://issues.apache.org/jira/browse/AURORA-30
Repository: aurora
Description
-------
Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file.
Diffs (updated)
-----
3rdparty/python/BUILD PRE-CREATION
aurora/twitterdeps/src/python/twitter/common/app/BUILD f77fea19a50c83bf4b69ffb151de5b13d3146aa3
aurora/twitterdeps/src/python/twitter/common/collections/BUILD eadff788b625a194e419fab074eca38743595568
aurora/twitterdeps/src/python/twitter/common/concurrent/BUILD bf7e007d50ac6f9bbb505933c3d8a4a2e76fa329
aurora/twitterdeps/src/python/twitter/common/config/BUILD fdb09af78fcfd400adbb2ca7240af2421057269d
aurora/twitterdeps/src/python/twitter/common/confluence/BUILD cad6ba1ac79e90302a709b96dae7158f90689262
aurora/twitterdeps/src/python/twitter/common/contextutil/BUILD 4baed1d3a58a2585c951361922f9acdcadeb87b6
aurora/twitterdeps/src/python/twitter/common/decorators/BUILD d2a378b28456823b84c118a24db160bdd8c00fe7
aurora/twitterdeps/src/python/twitter/common/dirutil/BUILD 199844ff170862d264fe73efbd718e09a12397f2
aurora/twitterdeps/src/python/twitter/common/exceptions/BUILD 358a2bdd6a95af22918eda23ed9aebd0f268230b
aurora/twitterdeps/src/python/twitter/common/http/BUILD f4460fcd220fc9423d0064ede3e7303aa52d8e5a
aurora/twitterdeps/src/python/twitter/common/lang/BUILD 471c1e51901c42bb658e629123fb3015b1881627
aurora/twitterdeps/src/python/twitter/common/log/BUILD 7dcd83e9910968388cb8d21c7ab765b2e5808910
aurora/twitterdeps/src/python/twitter/common/metrics/BUILD 25f21043d676c0fc16ff774e303d5caa47987d0a
aurora/twitterdeps/src/python/twitter/common/options/BUILD 6047d2609e9d472cb2f44dcf9bff19f9ffb561ad
aurora/twitterdeps/src/python/twitter/common/process/BUILD 661cbec8265105504900ee26edf148ae5e0ba9ac
aurora/twitterdeps/src/python/twitter/common/python/BUILD 88a1eca51588508800694be074a1578a7b2efd9d
aurora/twitterdeps/src/python/twitter/common/quantity/BUILD 479aaae6f21324f496d9061053c45832733e879d
aurora/twitterdeps/src/python/twitter/common/recordio/BUILD 4018def7e375fa9991216b5a360cc9f6e47d9f70
aurora/twitterdeps/src/python/twitter/common/rpc/BUILD 8cc60883829fa8ea911d993cfa3a8ff519691fc3
aurora/twitterdeps/src/python/twitter/common/rpc/transports/BUILD 1953302370ae4980198effc4aa9e9d5cf0916192
aurora/twitterdeps/src/python/twitter/common/string/BUILD ed5b958de9e001180036514e35963e1194ff3b5a
aurora/twitterdeps/src/python/twitter/common/testing/BUILD 3d28b4b2e0f50009dd4c04015a2eb1d39274d5da
aurora/twitterdeps/src/python/twitter/common/util/BUILD 807a05385684a01b243eeff3ddf1d2ea8111aa60
aurora/twitterdeps/src/python/twitter/common/zookeeper/BUILD f0a02ef44c033eb2a624fc58a50e7c50105d8cf4
aurora/twitterdeps/src/python/twitter/common/zookeeper/serverset/BUILD 11cb77ea45a1f569ab655306a948ad9581123c7f
aurora/twitterdeps/src/python/twitter/thermos/common/BUILD b04ed686c1f3263b82a51ff842f4851dab188b83
aurora/twitterdeps/src/python/twitter/thermos/config/BUILD 4b665533b56c24f2e5f7d2a3334e7e2949e01d88
aurora/twitterdeps/src/python/twitter/thermos/core/BUILD 3039970a26f321447f54f719fcc545310754a479
aurora/twitterdeps/src/python/twitter/thermos/monitoring/BUILD b5f6d0cfd80b557d5fcfe4d07073a2a7dbb77d81
aurora/twitterdeps/src/python/twitter/thermos/observer/BUILD 5861a73827a8aa87b6a412cd86428f796bb66666
aurora/twitterdeps/src/thrift/com/twitter/thermos/BUILD 8a9f8b8f969e02e0f409bc184b302f65323a47ef
aurora/twitterdeps/src/thrift/com/twitter/thrift/BUILD 400827cc2e61a54cd4523260aef9339a43a11842
src/main/python/apache/aurora/BUILD.thirdparty 7a43acae1edb5d0474d020a5edabbf687de589f9
src/main/python/apache/aurora/admin/BUILD 530b0cb5fa7b2d970937182638217b46c26824b4
src/main/python/apache/aurora/client/BUILD 1c967a57f04ccf6bfd166b917ce62c2236c0abff
src/main/python/apache/aurora/client/api/BUILD 358205e7321463ecee58c14331712c5792c83793
src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb
src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
src/main/python/apache/aurora/client/commands/BUILD e2322b8a333593e8bf1807916381db1dec69cee3
src/main/python/apache/aurora/client/hooks/BUILD d181f529e9e89534f5b07ec2ce508ba705a3c472
src/main/python/apache/aurora/common/BUILD 860667e50fdc2a4defc2033c08aee306dc5c9171
src/main/python/apache/aurora/common/auth/BUILD bd47654eccdc0868c2d813b4c461bc0b823257bb
src/main/python/apache/aurora/config/BUILD 39df20fef17b6e15e40ca72a463376bb49569949
src/main/python/apache/aurora/config/schema/BUILD 78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0
src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e
src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30
src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc
src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8
src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04
src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344
src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd
src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef358888
src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5
src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7
src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4
src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee
src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e
src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9
src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb
src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0
src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a
src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1
src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb
src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a
src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51
src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47
src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc
src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb
src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb
src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581
Diff: https://reviews.apache.org/r/17419/diff/
Testing
-------
Ran build-support/jenkins/build.sh and it passes all tests for java and python locally
Thanks,
Jake Farrell