You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/10/26 22:58:09 UTC
[GitHub] [incubator-teaclave] qinkunbao opened a new pull request #569: Fix leaked resources
qinkunbao opened a new pull request #569:
URL: https://github.com/apache/incubator-teaclave/pull/569
## Description
This PR fixes the resource leaks in WAMR.
https://github.com/bytecodealliance/wasm-micro-runtime/blob/51a00a4c2b60e50ae76ccd54c9f0db1c23555168/product-mini/platforms/posix/main.c#L443
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- Bug fix (non-breaking change which fixes an issue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] qinkunbao commented on pull request #569: [WAMR] Fix leaked resources
Posted by GitBox <gi...@apache.org>.
qinkunbao commented on pull request #569:
URL: https://github.com/apache/incubator-teaclave/pull/569#issuecomment-956764579
> Good to see unloading the WASM's workload gracefully by adding corresponding native callbacks and preventing resource from leaking. However, there is a following issue identified by CI
>
> ```
> thread '<unnamed>' panicked at 'assertion failed: self.buffer.is_empty() ||
> self.opt.cmp.cmp(self.last_key.as_slice(), key) == Ordering::Less', common/rusty_leveldb_sgx/src/block_builder.rs:60:9
> stack backtrace:
> ```
>
> It looks related to double release problem. probably need another patch to fix it ahead. thanks.
@bigdata-memory Thanks for the review. The CI issue has been patched in https://github.com/apache/incubator-teaclave/pull/570.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun merged pull request #569: [WAMR] Fix leaked resources
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #569:
URL: https://github.com/apache/incubator-teaclave/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] qinkunbao commented on pull request #569: [WAMR] Fix leaked resources
Posted by GitBox <gi...@apache.org>.
qinkunbao commented on pull request #569:
URL: https://github.com/apache/incubator-teaclave/pull/569#issuecomment-956764579
> Good to see unloading the WASM's workload gracefully by adding corresponding native callbacks and preventing resource from leaking. However, there is a following issue identified by CI
>
> ```
> thread '<unnamed>' panicked at 'assertion failed: self.buffer.is_empty() ||
> self.opt.cmp.cmp(self.last_key.as_slice(), key) == Ordering::Less', common/rusty_leveldb_sgx/src/block_builder.rs:60:9
> stack backtrace:
> ```
>
> It looks related to double release problem. probably need another patch to fix it ahead. thanks.
@bigdata-memory Thanks for the review. The CI issue has been patched in https://github.com/apache/incubator-teaclave/pull/570.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] qinkunbao commented on pull request #569: [WAMR] Fix leaked resources
Posted by GitBox <gi...@apache.org>.
qinkunbao commented on pull request #569:
URL: https://github.com/apache/incubator-teaclave/pull/569#issuecomment-956764579
> Good to see unloading the WASM's workload gracefully by adding corresponding native callbacks and preventing resource from leaking. However, there is a following issue identified by CI
>
> ```
> thread '<unnamed>' panicked at 'assertion failed: self.buffer.is_empty() ||
> self.opt.cmp.cmp(self.last_key.as_slice(), key) == Ordering::Less', common/rusty_leveldb_sgx/src/block_builder.rs:60:9
> stack backtrace:
> ```
>
> It looks related to double release problem. probably need another patch to fix it ahead. thanks.
@bigdata-memory Thanks for the review. The CI issue has been patched in https://github.com/apache/incubator-teaclave/pull/570.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun merged pull request #569: [WAMR] Fix leaked resources
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #569:
URL: https://github.com/apache/incubator-teaclave/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org