You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2019/07/29 12:54:45 UTC
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13944
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
IMPALA-8198: DATE: Read from avro.
This change is a follow-up to IMPALA-7368 and adds support for DATE
type to the avro scanner.
Similarly to parquet, avro uses DATE logical type for dates. DATE
logical type annotates an INT32 that stores the number of days since
the unix epoch, 1 January 1970.
This representation introduces an avro interoperability issue between
Impala and older versions of Hive:
- Before version 3.1, Hive used Julian calendar to represent dates
up to 1582-10-05 and Gregorian calendar for dates starting with
1582-10-15. Dates between 1582-10-05 and 1582-10-15 were lost.
- Impala uses proleptic Gregorian calendar, extending the Gregorian
calendar backward to dates preceding its official introduction in
1582-10-15.
This means that pre-1582-10-15 dates written to an avro table by Hive
will be read back incorrectly by Impala.
Note that Hive 3.1 switched to proleptic Gregorian calendar too, so
for Hive 3.1+ this is no longer an issue.
Dependency changes:
- BE uses avro 1.7.4-p5 from native-toolchain.
Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner-ir.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-avro-scanner.h
M be/src/util/avro-util.cc
M bin/impala-config.sh
M common/thrift/generate_error_codes.py
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M testdata/avro_schema_resolution/create_table.sql
M testdata/avro_schema_resolution/file_schema2.avsc
M testdata/avro_schema_resolution/records2.avro
M testdata/avro_schema_resolution/records2.json
M testdata/bad_avro_snap/README
A testdata/bad_avro_snap/hive2_pre_gregorian_date.avro
A testdata/bad_avro_snap/out_of_range_date.avro
M testdata/bin/generate-schema-statements.py
M testdata/data/README
M testdata/data/date_tbl.avro
A testdata/data/date_tbl.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test
A testdata/workloads/functional-query/queries/QueryTest/avro_date.test
M testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hive2-pre-gregorian-date.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-date.test
M tests/query_test/test_date_queries.py
35 files changed, 338 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/13944/1
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
IMPALA-8198: DATE: Read from avro.
This change is a follow-up to IMPALA-7368 and adds support for DATE
type to the avro scanner.
Similarly to parquet, avro uses DATE logical type for dates. DATE
logical type annotates an INT32 that stores the number of days since
the unix epoch, 1 January 1970.
This representation introduces an avro interoperability issue between
Impala and older versions of Hive:
- Before version 3.1, Hive used Julian calendar to represent dates
up to 1582-10-05 and Gregorian calendar for dates starting with
1582-10-15. Dates between 1582-10-05 and 1582-10-15 were lost.
- Impala uses proleptic Gregorian calendar, extending the Gregorian
calendar backward to dates preceding its official introduction in
1582-10-15.
This means that pre-1582-10-15 dates written to an avro table by Hive
will be read back incorrectly by Impala.
Note that Hive 3.1 switched to proleptic Gregorian calendar too, so
for Hive 3.1+ this is no longer an issue.
Dependency changes:
- BE uses avro 1.7.4-p5 from native-toolchain.
Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner-ir.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-avro-scanner.h
M be/src/util/avro-util.cc
M common/thrift/generate_error_codes.py
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M testdata/avro_schema_resolution/create_table.sql
M testdata/avro_schema_resolution/file_schema2.avsc
M testdata/avro_schema_resolution/records2.avro
M testdata/avro_schema_resolution/records2.json
M testdata/bad_avro_snap/README
A testdata/bad_avro_snap/hive2_pre_gregorian_date.avro
A testdata/bad_avro_snap/hive3_pre_gregorian_date.avro
A testdata/bad_avro_snap/out_of_range_date.avro
M testdata/bin/generate-schema-statements.py
M testdata/data/README
M testdata/data/date_tbl.avro
A testdata/data/date_tbl.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test
A testdata/workloads/functional-query/queries/QueryTest/avro_date.test
M testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hive2-pre-gregorian-date.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-date.test
M tests/query_test/test_date_queries.py
35 files changed, 435 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/13944/3
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Sep 2019 20:20:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13944/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13944/1//COMMIT_MSG@27
PS1, Line 27: Note that Hive 3.1 switched to proleptic Gregorian calendar too, so
I didn't see anything in the tests that expects different results for Hive 2 and 3. We support running tests with both Hive 2 and 3, so I would have expected to see something like that.
http://gerrit.cloudera.org:8080/#/c/13944/1/be/src/exec/hdfs-avro-scanner.cc
File be/src/exec/hdfs-avro-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/13944/1/be/src/exec/hdfs-avro-scanner.cc@1025
PS1, Line 1025: read_field_fn = codegen->GetFunction(IRFunction::READ_AVRO_DATE, false);
Why is the branch condition here different from the interpreted MaterializeTuple() function? In that function we were branching on both the schema type and the slot type.
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 22:06:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
IMPALA-8198: DATE: Read from avro.
This change is a follow-up to IMPALA-7368 and adds support for DATE
type to the avro scanner.
Similarly to parquet, avro uses DATE logical type for dates. DATE
logical type annotates an INT32 that stores the number of days since
the unix epoch, 1 January 1970.
This representation introduces an avro interoperability issue between
Impala and older versions of Hive:
- Before version 3.1, Hive used Julian calendar to represent dates
up to 1582-10-05 and Gregorian calendar for dates starting with
1582-10-15. Dates between 1582-10-05 and 1582-10-15 were lost.
- Impala uses proleptic Gregorian calendar, extending the Gregorian
calendar backward to dates preceding its official introduction in
1582-10-15.
This means that pre-1582-10-15 dates written to an avro table by Hive
will be read back incorrectly by Impala.
Note that Hive 3.1 switched to proleptic Gregorian calendar too, so
for Hive 3.1+ this is no longer an issue.
Dependency changes:
- BE uses avro 1.7.4-p5 from native-toolchain.
Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Reviewed-on: http://gerrit.cloudera.org:8080/13944
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner-ir.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-avro-scanner.h
M be/src/util/avro-util.cc
M common/thrift/generate_error_codes.py
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M testdata/avro_schema_resolution/create_table.sql
M testdata/avro_schema_resolution/file_schema2.avsc
M testdata/avro_schema_resolution/records2.avro
M testdata/avro_schema_resolution/records2.json
M testdata/bad_avro_snap/README
A testdata/bad_avro_snap/hive2_pre_gregorian_date.avro
A testdata/bad_avro_snap/hive3_pre_gregorian_date.avro
A testdata/bad_avro_snap/out_of_range_date.avro
M testdata/bin/generate-schema-statements.py
M testdata/data/README
M testdata/data/date_tbl.avro
A testdata/data/date_tbl.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test
A testdata/workloads/functional-query/queries/QueryTest/avro_date.test
M testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hive2-pre-gregorian-date.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-date.test
M tests/query_test/test_date_queries.py
35 files changed, 435 insertions(+), 76 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5014/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 12:56:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 12:56:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 3:
> Uploaded patch set 3.
The patch has been rebased.
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 12:57:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 17:18:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
IMPALA-8198: DATE: Read from avro.
This change is a follow-up to IMPALA-7368 and adds support for DATE
type to the avro scanner.
Similarly to parquet, avro uses DATE logical type for dates. DATE
logical type annotates an INT32 that stores the number of days since
the unix epoch, 1 January 1970.
This representation introduces an avro interoperability issue between
Impala and older versions of Hive:
- Before version 3.1, Hive used Julian calendar to represent dates
up to 1582-10-05 and Gregorian calendar for dates starting with
1582-10-15. Dates between 1582-10-05 and 1582-10-15 were lost.
- Impala uses proleptic Gregorian calendar, extending the Gregorian
calendar backward to dates preceding its official introduction in
1582-10-15.
This means that pre-1582-10-15 dates written to an avro table by Hive
will be read back incorrectly by Impala.
Note that Hive 3.1 switched to proleptic Gregorian calendar too, so
for Hive 3.1+ this is no longer an issue.
Dependency changes:
- BE uses avro 1.7.4-p5 from native-toolchain.
Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner-ir.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-avro-scanner.h
M be/src/util/avro-util.cc
M bin/impala-config.sh
M common/thrift/generate_error_codes.py
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M testdata/avro_schema_resolution/create_table.sql
M testdata/avro_schema_resolution/file_schema2.avsc
M testdata/avro_schema_resolution/records2.avro
M testdata/avro_schema_resolution/records2.json
M testdata/bad_avro_snap/README
A testdata/bad_avro_snap/hive2_pre_gregorian_date.avro
A testdata/bad_avro_snap/hive3_pre_gregorian_date.avro
A testdata/bad_avro_snap/out_of_range_date.avro
M testdata/bin/generate-schema-statements.py
M testdata/data/README
M testdata/data/date_tbl.avro
A testdata/data/date_tbl.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test
A testdata/workloads/functional-query/queries/QueryTest/avro_date.test
M testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hive2-pre-gregorian-date.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-date.test
M tests/query_test/test_date_queries.py
36 files changed, 437 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/13944/2
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4624/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 13:37:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4623/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 13:33:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )
Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4061/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jul 2019 13:36:02 +0000
Gerrit-HasComments: No