You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/07 07:50:46 UTC
[GitHub] [rocketmq-connect] odbozhou commented on a diff in pull request #386: [ISSUE #383]support failed task after connector restart
odbozhou commented on code in PR #386:
URL: https://github.com/apache/rocketmq-connect/pull/386#discussion_r1041857552
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/controller/AbstractConnectController.java:
##########
@@ -225,6 +225,25 @@ public void deleteConnectorConfig(String connectorName) {
configManagementService.deleteConnectorConfig(connectorName);
}
+ /**
+ * Restart the connector with the specified connector name in the cluster.
+ *
+ * @param connectorName
+ */
+ public void restartConnectorConfig(String connectorName) {
Review Comment:
restartConnector may be more appropriate than restartConnectorConfig
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementService.java:
##########
@@ -76,6 +76,21 @@ default void configure(WorkerConfig config) {
*/
void deleteConnectorConfig(String connectorName);
+ /**
+ * restart the connector with the specified connector name in the cluster.
+ *
+ * @param connectorName
+ */
+ void restartConnectorConfig(String connectorName);
+
+ /**
+ * restart the task with the specified task in the cluster.
+ *
+ * @param connectorName
+ * @param task
+ */
+ void restartTaskConfig(String connectorName, Integer task);
Review Comment:
restartTask may be more appropriate than restartTaskConfig
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementService.java:
##########
@@ -76,6 +76,21 @@ default void configure(WorkerConfig config) {
*/
void deleteConnectorConfig(String connectorName);
+ /**
+ * restart the connector with the specified connector name in the cluster.
+ *
+ * @param connectorName
+ */
+ void restartConnectorConfig(String connectorName);
Review Comment:
restartConnector may be more appropriate than restartConnectorConfig
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/controller/AbstractConnectController.java:
##########
@@ -225,6 +225,25 @@ public void deleteConnectorConfig(String connectorName) {
configManagementService.deleteConnectorConfig(connectorName);
}
+ /**
+ * Restart the connector with the specified connector name in the cluster.
+ *
+ * @param connectorName
+ */
+ public void restartConnectorConfig(String connectorName) {
+ configManagementService.restartConnectorConfig(connectorName);
+ }
+
+ /**
+ * Restart the task with the specified task name in the cluster.
+ *
+ * @param connectorName
+ * @param task
+ */
+ public void restartTaskConfig(String connectorName, Integer task) {
Review Comment:
restartTask may be more appropriate than restartTaskConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org