[GitHub] lanking520 commented on issue #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray

[GitBox <gi...@apache.org>]

lanking520 commented on issue #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray
URL: https://github.com/apache/incubator-mxnet/pull/12690#issuecomment-430704358
 
 
   > I am not comfortable adding this API, an analogy to NDArray is BufferedImage, you don't print all the pixel values of a BufferedImage in toString. I understand it helps with debugging, however i would expect the developer/user to use a debugger or override toString then.
   
   @nswamy two things I would like to mention:
   - the visualize method does not override `toString`.
   - the visualize method can smartly handle the large NDArray case. Please see my unittest examples. It would ignore most of the content and only print a part of it. It implementation is very similar to ndarray print function in Python

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services