You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Marcel Kinard <cm...@gmail.com> on 2012/12/13 16:44:44 UTC
mobile-spec failures on iOS 6.0.0
I ran the latest cordova-ios and mobile-spec on an iOS 6.0.0 iPhone 4S and
got 10 failures:
- 2 in File API
- 5 in FileTransfer
- 3 in Session Storage Local Storage
Is anyone else seeing these?
I took a look at the first one:
"File API read method should read file properly, File Object."
It looks like the text returned from readAsText() is URL encoded, which the
test case does not expect - it complains about "%20" not matching " ". I
looked at CDVFile.m and on line 936 it calls "messageAsString
stringByAddingPercentEscapesUsingEncoding". Are the contents returned from
readAsText() really supposed to be URL encoded? The Cordova doc doesn't
indicate that.
-- Marcel Kinard
Re: mobile-spec failures on iOS 6.0.0
Posted by Andrew Grieve <ag...@chromium.org>.
I committed this.
On Fri, Dec 14, 2012 at 2:43 PM, Shazron <sh...@gmail.com> wrote:
> For review -- cordova-js pull request filed:
> https://github.com/apache/cordova-js/pull/3
>
>
> On Fri, Dec 14, 2012 at 11:17 AM, Shazron <sh...@gmail.com> wrote:
>
> > Instead of doing the tag and test dance again for everybody, I'm going to
> > leave it as is for iOS rc2 even though it fails 2 File tests in rc2.
> These
> > should be addressed in the final 2.3.0. I'm away from Mon-Wed next week
> so
> > hopefully someone will address any iOS issues.
> >
> > I'll send a pull-request to cordova-js for review since it affects all
> > platforms.
> >
> >
> > On Thu, Dec 13, 2012 at 2:23 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> Furthermore, it used to clobber first, then merge:
> >>
> https://github.com/apache/cordova-js/commit/99fadd12f74703a58e729664394570956d6ccbe4#lib/scripts/bootstrap.js
> >>
> >> Ok, I'd like to change this but this requires everyone to grab a new
> >> cordova-js and re-test -- or I just tag iOS now with this fail and leave
> >> the fix for 2.3.0 final. What does everyone think?
> >>
> >>
> >> On Thu, Dec 13, 2012 at 2:20 PM, Shazron <sh...@gmail.com> wrote:
> >>
> >>> Found the culprit -- these two lines have to be reversed (which makes
> >>> sense -- clobber first, then merge, not the other way around):
> >>>
> >>>
> https://github.com/apache/cordova-js/blob/99fadd12f74703a58e729664394570956d6ccbe4/lib/scripts/bootstrap.js#L48-49
> >>>
> >>> Unfortunately, this is an all-platform change to cordova-js :/
> >>>
> >>>
> >>> On Thu, Dec 13, 2012 at 2:07 PM, Shazron <sh...@gmail.com> wrote:
> >>>
> >>>> Becky and I were debugging this. In lib/ios/platform.js, it seems
> >>>> FileReader is clobbered in the "clobbers" section but the iOS specific
> >>>> FileReader is not merged in the "merges" section. Not sure why yet.
> >>>>
> >>>>
> >>>> On Thu, Dec 13, 2012 at 1:22 PM, Becky Gibson <gibson.becky@gmail.com
> >wrote:
> >>>>
> >>>>> So, it seems that the iOS specific version of readAsText is NOT being
> >>>>> called and the "standard" one is being used. The iOS version of
> >>>>> readAsText
> >>>>> performs the necessary decode. The iOS version IS in the cordova.js
> >>>>> file
> >>>>> but I haven't debugged enough to see why it is not being used.
> >>>>>
> >>>>> -becky
> >>>>>
> >>>>>
> >>>>> On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
> >>>>>
> >>>>> > Thanks Becky -- i'll take a peek as well. Filed:
> >>>>> > http://issues.cordova.io/2058
> >>>>> >
> >>>>> >
> >>>>> > On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <
> >>>>> gibson.becky@gmail.com
> >>>>> > >wrote:
> >>>>> >
> >>>>> > > So, I thought the encoding was necessary for internationalization
> >>>>> and any
> >>>>> > > special characters in the file data (for example a URL)? Do all
> >>>>> of the
> >>>>> > > other file tests still run with this change? We're there any
> >>>>> changes to
> >>>>> > > the file tests themselves? I try to take a look this afternoon.
> >>>>> > >
> >>>>> > > - Becky
> >>>>> > >
> >>>>> > > Sent from my iPad
> >>>>> > >
> >>>>> > > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com>
> >>>>> wrote:
> >>>>> > >
> >>>>> > > > Yup, I see that file-transfer.jitsu.com is returning a page
> >>>>> saying:
> >>>>> > > >
> >>>>> > > > An error has occurred:
> >>>>> > > >
> >>>>> {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
> >>>>> > > >
> >>>>> > > > Something is obviously dead there. So yeah, ignore those test
> >>>>> failures
> >>>>> > as
> >>>>> > > > an infrastructure problem.
> >>>>> > > >
> >>>>> > > > Your File API failures look like the ones I was getting. If I
> >>>>> modify
> >>>>> > > > readAsText: from
> >>>>> > > >
> >>>>> > > > messageAsString:[pNStrBuff
> >>>>> > > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
> >>>>> > > >
> >>>>> > > > to
> >>>>> > > >
> >>>>> > > > messageAsString:[NSString stringWithString:pNStrBuff]
> >>>>> > > > then those failures disappear. So I'm still puzzled if it is
> >>>>> really
> >>>>> > > > supposed to be URL encoding the result message.
> >>>>> > > >
> >>>>> > > > BTW, I noticed in your screenshot that your testsuite has 95
> >>>>> tests.
> >>>>> > Mine
> >>>>> > > > has 238. Are we using the same version of mobile-spec?
> >>>>> > > >
> >>>>> > > > -- Marcel
> >>>>> > >
> >>>>> >
> >>>>>
> >>>>
> >>>>
> >>>
> >>
> >
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
For review -- cordova-js pull request filed:
https://github.com/apache/cordova-js/pull/3
On Fri, Dec 14, 2012 at 11:17 AM, Shazron <sh...@gmail.com> wrote:
> Instead of doing the tag and test dance again for everybody, I'm going to
> leave it as is for iOS rc2 even though it fails 2 File tests in rc2. These
> should be addressed in the final 2.3.0. I'm away from Mon-Wed next week so
> hopefully someone will address any iOS issues.
>
> I'll send a pull-request to cordova-js for review since it affects all
> platforms.
>
>
> On Thu, Dec 13, 2012 at 2:23 PM, Shazron <sh...@gmail.com> wrote:
>
>> Furthermore, it used to clobber first, then merge:
>> https://github.com/apache/cordova-js/commit/99fadd12f74703a58e729664394570956d6ccbe4#lib/scripts/bootstrap.js
>>
>> Ok, I'd like to change this but this requires everyone to grab a new
>> cordova-js and re-test -- or I just tag iOS now with this fail and leave
>> the fix for 2.3.0 final. What does everyone think?
>>
>>
>> On Thu, Dec 13, 2012 at 2:20 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> Found the culprit -- these two lines have to be reversed (which makes
>>> sense -- clobber first, then merge, not the other way around):
>>>
>>> https://github.com/apache/cordova-js/blob/99fadd12f74703a58e729664394570956d6ccbe4/lib/scripts/bootstrap.js#L48-49
>>>
>>> Unfortunately, this is an all-platform change to cordova-js :/
>>>
>>>
>>> On Thu, Dec 13, 2012 at 2:07 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>>> Becky and I were debugging this. In lib/ios/platform.js, it seems
>>>> FileReader is clobbered in the "clobbers" section but the iOS specific
>>>> FileReader is not merged in the "merges" section. Not sure why yet.
>>>>
>>>>
>>>> On Thu, Dec 13, 2012 at 1:22 PM, Becky Gibson <gi...@gmail.com>wrote:
>>>>
>>>>> So, it seems that the iOS specific version of readAsText is NOT being
>>>>> called and the "standard" one is being used. The iOS version of
>>>>> readAsText
>>>>> performs the necessary decode. The iOS version IS in the cordova.js
>>>>> file
>>>>> but I haven't debugged enough to see why it is not being used.
>>>>>
>>>>> -becky
>>>>>
>>>>>
>>>>> On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
>>>>>
>>>>> > Thanks Becky -- i'll take a peek as well. Filed:
>>>>> > http://issues.cordova.io/2058
>>>>> >
>>>>> >
>>>>> > On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <
>>>>> gibson.becky@gmail.com
>>>>> > >wrote:
>>>>> >
>>>>> > > So, I thought the encoding was necessary for internationalization
>>>>> and any
>>>>> > > special characters in the file data (for example a URL)? Do all
>>>>> of the
>>>>> > > other file tests still run with this change? We're there any
>>>>> changes to
>>>>> > > the file tests themselves? I try to take a look this afternoon.
>>>>> > >
>>>>> > > - Becky
>>>>> > >
>>>>> > > Sent from my iPad
>>>>> > >
>>>>> > > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com>
>>>>> wrote:
>>>>> > >
>>>>> > > > Yup, I see that file-transfer.jitsu.com is returning a page
>>>>> saying:
>>>>> > > >
>>>>> > > > An error has occurred:
>>>>> > > >
>>>>> {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
>>>>> > > >
>>>>> > > > Something is obviously dead there. So yeah, ignore those test
>>>>> failures
>>>>> > as
>>>>> > > > an infrastructure problem.
>>>>> > > >
>>>>> > > > Your File API failures look like the ones I was getting. If I
>>>>> modify
>>>>> > > > readAsText: from
>>>>> > > >
>>>>> > > > messageAsString:[pNStrBuff
>>>>> > > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>>>>> > > >
>>>>> > > > to
>>>>> > > >
>>>>> > > > messageAsString:[NSString stringWithString:pNStrBuff]
>>>>> > > > then those failures disappear. So I'm still puzzled if it is
>>>>> really
>>>>> > > > supposed to be URL encoding the result message.
>>>>> > > >
>>>>> > > > BTW, I noticed in your screenshot that your testsuite has 95
>>>>> tests.
>>>>> > Mine
>>>>> > > > has 238. Are we using the same version of mobile-spec?
>>>>> > > >
>>>>> > > > -- Marcel
>>>>> > >
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Instead of doing the tag and test dance again for everybody, I'm going to
leave it as is for iOS rc2 even though it fails 2 File tests in rc2. These
should be addressed in the final 2.3.0. I'm away from Mon-Wed next week so
hopefully someone will address any iOS issues.
I'll send a pull-request to cordova-js for review since it affects all
platforms.
On Thu, Dec 13, 2012 at 2:23 PM, Shazron <sh...@gmail.com> wrote:
> Furthermore, it used to clobber first, then merge:
> https://github.com/apache/cordova-js/commit/99fadd12f74703a58e729664394570956d6ccbe4#lib/scripts/bootstrap.js
>
> Ok, I'd like to change this but this requires everyone to grab a new
> cordova-js and re-test -- or I just tag iOS now with this fail and leave
> the fix for 2.3.0 final. What does everyone think?
>
>
> On Thu, Dec 13, 2012 at 2:20 PM, Shazron <sh...@gmail.com> wrote:
>
>> Found the culprit -- these two lines have to be reversed (which makes
>> sense -- clobber first, then merge, not the other way around):
>>
>> https://github.com/apache/cordova-js/blob/99fadd12f74703a58e729664394570956d6ccbe4/lib/scripts/bootstrap.js#L48-49
>>
>> Unfortunately, this is an all-platform change to cordova-js :/
>>
>>
>> On Thu, Dec 13, 2012 at 2:07 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> Becky and I were debugging this. In lib/ios/platform.js, it seems
>>> FileReader is clobbered in the "clobbers" section but the iOS specific
>>> FileReader is not merged in the "merges" section. Not sure why yet.
>>>
>>>
>>> On Thu, Dec 13, 2012 at 1:22 PM, Becky Gibson <gi...@gmail.com>wrote:
>>>
>>>> So, it seems that the iOS specific version of readAsText is NOT being
>>>> called and the "standard" one is being used. The iOS version of
>>>> readAsText
>>>> performs the necessary decode. The iOS version IS in the cordova.js
>>>> file
>>>> but I haven't debugged enough to see why it is not being used.
>>>>
>>>> -becky
>>>>
>>>>
>>>> On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
>>>>
>>>> > Thanks Becky -- i'll take a peek as well. Filed:
>>>> > http://issues.cordova.io/2058
>>>> >
>>>> >
>>>> > On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <
>>>> gibson.becky@gmail.com
>>>> > >wrote:
>>>> >
>>>> > > So, I thought the encoding was necessary for internationalization
>>>> and any
>>>> > > special characters in the file data (for example a URL)? Do all of
>>>> the
>>>> > > other file tests still run with this change? We're there any
>>>> changes to
>>>> > > the file tests themselves? I try to take a look this afternoon.
>>>> > >
>>>> > > - Becky
>>>> > >
>>>> > > Sent from my iPad
>>>> > >
>>>> > > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com>
>>>> wrote:
>>>> > >
>>>> > > > Yup, I see that file-transfer.jitsu.com is returning a page
>>>> saying:
>>>> > > >
>>>> > > > An error has occurred:
>>>> > > > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
>>>> > > >
>>>> > > > Something is obviously dead there. So yeah, ignore those test
>>>> failures
>>>> > as
>>>> > > > an infrastructure problem.
>>>> > > >
>>>> > > > Your File API failures look like the ones I was getting. If I
>>>> modify
>>>> > > > readAsText: from
>>>> > > >
>>>> > > > messageAsString:[pNStrBuff
>>>> > > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>>>> > > >
>>>> > > > to
>>>> > > >
>>>> > > > messageAsString:[NSString stringWithString:pNStrBuff]
>>>> > > > then those failures disappear. So I'm still puzzled if it is
>>>> really
>>>> > > > supposed to be URL encoding the result message.
>>>> > > >
>>>> > > > BTW, I noticed in your screenshot that your testsuite has 95
>>>> tests.
>>>> > Mine
>>>> > > > has 238. Are we using the same version of mobile-spec?
>>>> > > >
>>>> > > > -- Marcel
>>>> > >
>>>> >
>>>>
>>>
>>>
>>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Furthermore, it used to clobber first, then merge:
https://github.com/apache/cordova-js/commit/99fadd12f74703a58e729664394570956d6ccbe4#lib/scripts/bootstrap.js
Ok, I'd like to change this but this requires everyone to grab a new
cordova-js and re-test -- or I just tag iOS now with this fail and leave
the fix for 2.3.0 final. What does everyone think?
On Thu, Dec 13, 2012 at 2:20 PM, Shazron <sh...@gmail.com> wrote:
> Found the culprit -- these two lines have to be reversed (which makes
> sense -- clobber first, then merge, not the other way around):
>
> https://github.com/apache/cordova-js/blob/99fadd12f74703a58e729664394570956d6ccbe4/lib/scripts/bootstrap.js#L48-49
>
> Unfortunately, this is an all-platform change to cordova-js :/
>
>
> On Thu, Dec 13, 2012 at 2:07 PM, Shazron <sh...@gmail.com> wrote:
>
>> Becky and I were debugging this. In lib/ios/platform.js, it seems
>> FileReader is clobbered in the "clobbers" section but the iOS specific
>> FileReader is not merged in the "merges" section. Not sure why yet.
>>
>>
>> On Thu, Dec 13, 2012 at 1:22 PM, Becky Gibson <gi...@gmail.com>wrote:
>>
>>> So, it seems that the iOS specific version of readAsText is NOT being
>>> called and the "standard" one is being used. The iOS version of
>>> readAsText
>>> performs the necessary decode. The iOS version IS in the cordova.js file
>>> but I haven't debugged enough to see why it is not being used.
>>>
>>> -becky
>>>
>>>
>>> On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>> > Thanks Becky -- i'll take a peek as well. Filed:
>>> > http://issues.cordova.io/2058
>>> >
>>> >
>>> > On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <gibson.becky@gmail.com
>>> > >wrote:
>>> >
>>> > > So, I thought the encoding was necessary for internationalization
>>> and any
>>> > > special characters in the file data (for example a URL)? Do all of
>>> the
>>> > > other file tests still run with this change? We're there any
>>> changes to
>>> > > the file tests themselves? I try to take a look this afternoon.
>>> > >
>>> > > - Becky
>>> > >
>>> > > Sent from my iPad
>>> > >
>>> > > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com>
>>> wrote:
>>> > >
>>> > > > Yup, I see that file-transfer.jitsu.com is returning a page
>>> saying:
>>> > > >
>>> > > > An error has occurred:
>>> > > > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
>>> > > >
>>> > > > Something is obviously dead there. So yeah, ignore those test
>>> failures
>>> > as
>>> > > > an infrastructure problem.
>>> > > >
>>> > > > Your File API failures look like the ones I was getting. If I
>>> modify
>>> > > > readAsText: from
>>> > > >
>>> > > > messageAsString:[pNStrBuff
>>> > > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>>> > > >
>>> > > > to
>>> > > >
>>> > > > messageAsString:[NSString stringWithString:pNStrBuff]
>>> > > > then those failures disappear. So I'm still puzzled if it is really
>>> > > > supposed to be URL encoding the result message.
>>> > > >
>>> > > > BTW, I noticed in your screenshot that your testsuite has 95 tests.
>>> > Mine
>>> > > > has 238. Are we using the same version of mobile-spec?
>>> > > >
>>> > > > -- Marcel
>>> > >
>>> >
>>>
>>
>>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Found the culprit -- these two lines have to be reversed (which makes sense
-- clobber first, then merge, not the other way around):
https://github.com/apache/cordova-js/blob/99fadd12f74703a58e729664394570956d6ccbe4/lib/scripts/bootstrap.js#L48-49
Unfortunately, this is an all-platform change to cordova-js :/
On Thu, Dec 13, 2012 at 2:07 PM, Shazron <sh...@gmail.com> wrote:
> Becky and I were debugging this. In lib/ios/platform.js, it seems
> FileReader is clobbered in the "clobbers" section but the iOS specific
> FileReader is not merged in the "merges" section. Not sure why yet.
>
>
> On Thu, Dec 13, 2012 at 1:22 PM, Becky Gibson <gi...@gmail.com>wrote:
>
>> So, it seems that the iOS specific version of readAsText is NOT being
>> called and the "standard" one is being used. The iOS version of
>> readAsText
>> performs the necessary decode. The iOS version IS in the cordova.js file
>> but I haven't debugged enough to see why it is not being used.
>>
>> -becky
>>
>>
>> On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
>>
>> > Thanks Becky -- i'll take a peek as well. Filed:
>> > http://issues.cordova.io/2058
>> >
>> >
>> > On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <gibson.becky@gmail.com
>> > >wrote:
>> >
>> > > So, I thought the encoding was necessary for internationalization and
>> any
>> > > special characters in the file data (for example a URL)? Do all of
>> the
>> > > other file tests still run with this change? We're there any changes
>> to
>> > > the file tests themselves? I try to take a look this afternoon.
>> > >
>> > > - Becky
>> > >
>> > > Sent from my iPad
>> > >
>> > > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com>
>> wrote:
>> > >
>> > > > Yup, I see that file-transfer.jitsu.com is returning a page saying:
>> > > >
>> > > > An error has occurred:
>> > > > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
>> > > >
>> > > > Something is obviously dead there. So yeah, ignore those test
>> failures
>> > as
>> > > > an infrastructure problem.
>> > > >
>> > > > Your File API failures look like the ones I was getting. If I modify
>> > > > readAsText: from
>> > > >
>> > > > messageAsString:[pNStrBuff
>> > > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>> > > >
>> > > > to
>> > > >
>> > > > messageAsString:[NSString stringWithString:pNStrBuff]
>> > > > then those failures disappear. So I'm still puzzled if it is really
>> > > > supposed to be URL encoding the result message.
>> > > >
>> > > > BTW, I noticed in your screenshot that your testsuite has 95 tests.
>> > Mine
>> > > > has 238. Are we using the same version of mobile-spec?
>> > > >
>> > > > -- Marcel
>> > >
>> >
>>
>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Becky and I were debugging this. In lib/ios/platform.js, it seems
FileReader is clobbered in the "clobbers" section but the iOS specific
FileReader is not merged in the "merges" section. Not sure why yet.
On Thu, Dec 13, 2012 at 1:22 PM, Becky Gibson <gi...@gmail.com>wrote:
> So, it seems that the iOS specific version of readAsText is NOT being
> called and the "standard" one is being used. The iOS version of readAsText
> performs the necessary decode. The iOS version IS in the cordova.js file
> but I haven't debugged enough to see why it is not being used.
>
> -becky
>
>
> On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
>
> > Thanks Becky -- i'll take a peek as well. Filed:
> > http://issues.cordova.io/2058
> >
> >
> > On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <gibson.becky@gmail.com
> > >wrote:
> >
> > > So, I thought the encoding was necessary for internationalization and
> any
> > > special characters in the file data (for example a URL)? Do all of the
> > > other file tests still run with this change? We're there any changes
> to
> > > the file tests themselves? I try to take a look this afternoon.
> > >
> > > - Becky
> > >
> > > Sent from my iPad
> > >
> > > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com> wrote:
> > >
> > > > Yup, I see that file-transfer.jitsu.com is returning a page saying:
> > > >
> > > > An error has occurred:
> > > > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
> > > >
> > > > Something is obviously dead there. So yeah, ignore those test
> failures
> > as
> > > > an infrastructure problem.
> > > >
> > > > Your File API failures look like the ones I was getting. If I modify
> > > > readAsText: from
> > > >
> > > > messageAsString:[pNStrBuff
> > > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
> > > >
> > > > to
> > > >
> > > > messageAsString:[NSString stringWithString:pNStrBuff]
> > > > then those failures disappear. So I'm still puzzled if it is really
> > > > supposed to be URL encoding the result message.
> > > >
> > > > BTW, I noticed in your screenshot that your testsuite has 95 tests.
> > Mine
> > > > has 238. Are we using the same version of mobile-spec?
> > > >
> > > > -- Marcel
> > >
> >
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Becky Gibson <gi...@gmail.com>.
So, it seems that the iOS specific version of readAsText is NOT being
called and the "standard" one is being used. The iOS version of readAsText
performs the necessary decode. The iOS version IS in the cordova.js file
but I haven't debugged enough to see why it is not being used.
-becky
On Thu, Dec 13, 2012 at 4:08 PM, Shazron <sh...@gmail.com> wrote:
> Thanks Becky -- i'll take a peek as well. Filed:
> http://issues.cordova.io/2058
>
>
> On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <gibson.becky@gmail.com
> >wrote:
>
> > So, I thought the encoding was necessary for internationalization and any
> > special characters in the file data (for example a URL)? Do all of the
> > other file tests still run with this change? We're there any changes to
> > the file tests themselves? I try to take a look this afternoon.
> >
> > - Becky
> >
> > Sent from my iPad
> >
> > On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com> wrote:
> >
> > > Yup, I see that file-transfer.jitsu.com is returning a page saying:
> > >
> > > An error has occurred:
> > > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
> > >
> > > Something is obviously dead there. So yeah, ignore those test failures
> as
> > > an infrastructure problem.
> > >
> > > Your File API failures look like the ones I was getting. If I modify
> > > readAsText: from
> > >
> > > messageAsString:[pNStrBuff
> > > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
> > >
> > > to
> > >
> > > messageAsString:[NSString stringWithString:pNStrBuff]
> > > then those failures disappear. So I'm still puzzled if it is really
> > > supposed to be URL encoding the result message.
> > >
> > > BTW, I noticed in your screenshot that your testsuite has 95 tests.
> Mine
> > > has 238. Are we using the same version of mobile-spec?
> > >
> > > -- Marcel
> >
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Thanks Becky -- i'll take a peek as well. Filed:
http://issues.cordova.io/2058
On Thu, Dec 13, 2012 at 12:18 PM, Becky Gibson <gi...@gmail.com>wrote:
> So, I thought the encoding was necessary for internationalization and any
> special characters in the file data (for example a URL)? Do all of the
> other file tests still run with this change? We're there any changes to
> the file tests themselves? I try to take a look this afternoon.
>
> - Becky
>
> Sent from my iPad
>
> On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com> wrote:
>
> > Yup, I see that file-transfer.jitsu.com is returning a page saying:
> >
> > An error has occurred:
> > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
> >
> > Something is obviously dead there. So yeah, ignore those test failures as
> > an infrastructure problem.
> >
> > Your File API failures look like the ones I was getting. If I modify
> > readAsText: from
> >
> > messageAsString:[pNStrBuff
> > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
> >
> > to
> >
> > messageAsString:[NSString stringWithString:pNStrBuff]
> > then those failures disappear. So I'm still puzzled if it is really
> > supposed to be URL encoding the result message.
> >
> > BTW, I noticed in your screenshot that your testsuite has 95 tests. Mine
> > has 238. Are we using the same version of mobile-spec?
> >
> > -- Marcel
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Becky Gibson <gi...@gmail.com>.
So, I thought the encoding was necessary for internationalization and any special characters in the file data (for example a URL)? Do all of the other file tests still run with this change? We're there any changes to the file tests themselves? I try to take a look this afternoon.
- Becky
Sent from my iPad
On Dec 13, 2012, at 2:15 PM, Marcel Kinard <cm...@gmail.com> wrote:
> Yup, I see that file-transfer.jitsu.com is returning a page saying:
>
> An error has occurred:
> {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
>
> Something is obviously dead there. So yeah, ignore those test failures as
> an infrastructure problem.
>
> Your File API failures look like the ones I was getting. If I modify
> readAsText: from
>
> messageAsString:[pNStrBuff
> stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>
> to
>
> messageAsString:[NSString stringWithString:pNStrBuff]
> then those failures disappear. So I'm still puzzled if it is really
> supposed to be URL encoding the result message.
>
> BTW, I noticed in your screenshot that your testsuite has 95 tests. Mine
> has 238. Are we using the same version of mobile-spec?
>
> -- Marcel
Re: mobile-spec failures on iOS 6.0.0
Posted by Marcel Kinard <cm...@gmail.com>.
For the record, Becky did point me to the matching decoder in the js:
https://github.com/apache/cordova-js/blob/master/lib/ios/plugin/ios/FileReader.js#L65
So yes, now I see that URL encoding the result message is desired.
-- Marcel
On 12/13/2012 2:15 PM, Marcel Kinard wrote:
> Yup, I see that file-transfer.jitsu.com
> <http://file-transfer.jitsu.com> is returning a page saying:
> An error has occurred: {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
> Something is obviously dead there. So yeah, ignore those test failures
> as an infrastructure problem.
>
> Your File API failures look like the ones I was getting. If I modify
> readAsText: from
>
> messageAsString:[pNStrBuff
> stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>
> to
>
> messageAsString:[NSStringstringWithString:pNStrBuff]
>
> then those failures disappear. So I'm still puzzled if it is really
> supposed to be URL encoding the result message.
>
> BTW, I noticed in your screenshot that your testsuite has 95 tests.
> Mine has 238. Are we using the same version of mobile-spec?
>
> -- Marcel
Re: mobile-spec failures on iOS 6.0.0
Posted by Marcel Kinard <cm...@gmail.com>.
Ah, I see, yes, I also have 95 tests in File.
I created https://issues.apache.org/jira/browse/CB-2056 to address getting
file-transfer.jitsu.com back up and running.
On Thu, Dec 13, 2012 at 2:31 PM, Shazron <sh...@gmail.com> wrote:
> We are. I was just testing File Tests, not All Tests. I didn't see any File
> test changes since rc1 so it must be a native change.
>
>
> On Thu, Dec 13, 2012 at 11:15 AM, Marcel Kinard <cm...@gmail.com>
> wrote:
>
> > Yup, I see that file-transfer.jitsu.com is returning a page saying:
> >
> > An error has occurred:
> > {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
> >
> > Something is obviously dead there. So yeah, ignore those test failures as
> > an infrastructure problem.
> >
> > Your File API failures look like the ones I was getting. If I modify
> > readAsText: from
> >
> > messageAsString:[pNStrBuff
> > stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
> >
> > to
> >
> > messageAsString:[NSString stringWithString:pNStrBuff]
> > then those failures disappear. So I'm still puzzled if it is really
> > supposed to be URL encoding the result message.
> >
> > BTW, I noticed in your screenshot that your testsuite has 95 tests. Mine
> > has 238. Are we using the same version of mobile-spec?
> >
> > -- Marcel
> >
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
We are. I was just testing File Tests, not All Tests. I didn't see any File
test changes since rc1 so it must be a native change.
On Thu, Dec 13, 2012 at 11:15 AM, Marcel Kinard <cm...@gmail.com> wrote:
> Yup, I see that file-transfer.jitsu.com is returning a page saying:
>
> An error has occurred:
> {"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
>
> Something is obviously dead there. So yeah, ignore those test failures as
> an infrastructure problem.
>
> Your File API failures look like the ones I was getting. If I modify
> readAsText: from
>
> messageAsString:[pNStrBuff
> stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
>
> to
>
> messageAsString:[NSString stringWithString:pNStrBuff]
> then those failures disappear. So I'm still puzzled if it is really
> supposed to be URL encoding the result message.
>
> BTW, I noticed in your screenshot that your testsuite has 95 tests. Mine
> has 238. Are we using the same version of mobile-spec?
>
> -- Marcel
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Marcel Kinard <cm...@gmail.com>.
Yup, I see that file-transfer.jitsu.com is returning a page saying:
An error has occurred:
{"code":"ECONNREFUSED","errno":"ECONNREFUSED","syscall":"connect"}
Something is obviously dead there. So yeah, ignore those test failures as
an infrastructure problem.
Your File API failures look like the ones I was getting. If I modify
readAsText: from
messageAsString:[pNStrBuff
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
to
messageAsString:[NSString stringWithString:pNStrBuff]
then those failures disappear. So I'm still puzzled if it is really
supposed to be URL encoding the result message.
BTW, I noticed in your screenshot that your testsuite has 95 tests. Mine
has 238. Are we using the same version of mobile-spec?
-- Marcel
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Trying again. Apache rejected my reply because of a high spam score :/
We can rule out the FileTransfer ones since they have an external
dependency on a server that is erroring out:
http://cordova-filetransfer.jitsu.com<http://cordova-filetransfer.jitsu.com/robots.txt>
I
ran the File API tests only, here are the two errors: http://cl.ly/LZeW
Shaz
On Thu, Dec 13, 2012 at 10:32 AM, Shazron <sh...@gmail.com> wrote:
> Ok I can confirm 7 failures:
> - 2 in File API
> - 5 in FileTransfer
>
> But no failures with Session Storage Local Storage. Investigating to see
> what the changes are between rc1 and rc2.
>
>
>
> On Thu, Dec 13, 2012 at 9:15 AM, Shazron <sh...@gmail.com> wrote:
>
>> Which version? Definitely not in 2.3.0rc1
>> I'm testing 2.3.0rc2 today.
>>
>>
>> On Thu, Dec 13, 2012 at 7:44 AM, Marcel Kinard <cm...@gmail.com>wrote:
>>
>>> I ran the latest cordova-ios and mobile-spec on an iOS 6.0.0 iPhone 4S
>>> and
>>> got 10 failures:
>>> - 2 in File API
>>> - 5 in FileTransfer
>>> - 3 in Session Storage Local Storage
>>> Is anyone else seeing these?
>>>
>>> I took a look at the first one:
>>> "File API read method should read file properly, File Object."
>>> It looks like the text returned from readAsText() is URL encoded, which
>>> the
>>> test case does not expect - it complains about "%20" not matching " ". I
>>> looked at CDVFile.m and on line 936 it calls "messageAsString
>>> stringByAddingPercentEscapesUsingEncoding". Are the contents returned
>>> from
>>> readAsText() really supposed to be URL encoded? The Cordova doc doesn't
>>> indicate that.
>>>
>>> -- Marcel Kinard
>>>
>>
>>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
(also I was testing with 6.0.1)
On Thu, Dec 13, 2012 at 10:32 AM, Shazron <sh...@gmail.com> wrote:
> Ok I can confirm 7 failures:
> - 2 in File API
> - 5 in FileTransfer
>
> But no failures with Session Storage Local Storage. Investigating to see
> what the changes are between rc1 and rc2.
>
>
>
> On Thu, Dec 13, 2012 at 9:15 AM, Shazron <sh...@gmail.com> wrote:
>
>> Which version? Definitely not in 2.3.0rc1
>> I'm testing 2.3.0rc2 today.
>>
>>
>> On Thu, Dec 13, 2012 at 7:44 AM, Marcel Kinard <cm...@gmail.com>wrote:
>>
>>> I ran the latest cordova-ios and mobile-spec on an iOS 6.0.0 iPhone 4S
>>> and
>>> got 10 failures:
>>> - 2 in File API
>>> - 5 in FileTransfer
>>> - 3 in Session Storage Local Storage
>>> Is anyone else seeing these?
>>>
>>> I took a look at the first one:
>>> "File API read method should read file properly, File Object."
>>> It looks like the text returned from readAsText() is URL encoded, which
>>> the
>>> test case does not expect - it complains about "%20" not matching " ". I
>>> looked at CDVFile.m and on line 936 it calls "messageAsString
>>> stringByAddingPercentEscapesUsingEncoding". Are the contents returned
>>> from
>>> readAsText() really supposed to be URL encoded? The Cordova doc doesn't
>>> indicate that.
>>>
>>> -- Marcel Kinard
>>>
>>
>>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Ok I can confirm 7 failures:
- 2 in File API
- 5 in FileTransfer
But no failures with Session Storage Local Storage. Investigating to see
what the changes are between rc1 and rc2.
On Thu, Dec 13, 2012 at 9:15 AM, Shazron <sh...@gmail.com> wrote:
> Which version? Definitely not in 2.3.0rc1
> I'm testing 2.3.0rc2 today.
>
>
> On Thu, Dec 13, 2012 at 7:44 AM, Marcel Kinard <cm...@gmail.com> wrote:
>
>> I ran the latest cordova-ios and mobile-spec on an iOS 6.0.0 iPhone 4S and
>> got 10 failures:
>> - 2 in File API
>> - 5 in FileTransfer
>> - 3 in Session Storage Local Storage
>> Is anyone else seeing these?
>>
>> I took a look at the first one:
>> "File API read method should read file properly, File Object."
>> It looks like the text returned from readAsText() is URL encoded, which
>> the
>> test case does not expect - it complains about "%20" not matching " ". I
>> looked at CDVFile.m and on line 936 it calls "messageAsString
>> stringByAddingPercentEscapesUsingEncoding". Are the contents returned from
>> readAsText() really supposed to be URL encoded? The Cordova doc doesn't
>> indicate that.
>>
>> -- Marcel Kinard
>>
>
>
Re: mobile-spec failures on iOS 6.0.0
Posted by Shazron <sh...@gmail.com>.
Which version? Definitely not in 2.3.0rc1
I'm testing 2.3.0rc2 today.
On Thu, Dec 13, 2012 at 7:44 AM, Marcel Kinard <cm...@gmail.com> wrote:
> I ran the latest cordova-ios and mobile-spec on an iOS 6.0.0 iPhone 4S and
> got 10 failures:
> - 2 in File API
> - 5 in FileTransfer
> - 3 in Session Storage Local Storage
> Is anyone else seeing these?
>
> I took a look at the first one:
> "File API read method should read file properly, File Object."
> It looks like the text returned from readAsText() is URL encoded, which the
> test case does not expect - it complains about "%20" not matching " ". I
> looked at CDVFile.m and on line 936 it calls "messageAsString
> stringByAddingPercentEscapesUsingEncoding". Are the contents returned from
> readAsText() really supposed to be URL encoded? The Cordova doc doesn't
> indicate that.
>
> -- Marcel Kinard
>