You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "SiyaoIsHiding (via GitHub)" <gi...@apache.org> on 2026/05/19 23:46:06 UTC
[PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
SiyaoIsHiding opened a new pull request, #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461
A lot of things broke, but don't panic!
This is the first PR for the typescript migration, mainly for the file extension rename, so that `git diff` will actually work in the future.
A very simple tsconfig is included so that you can at least run a command like `npx ts-mocha test/unit/metadata-tests.ts` to ensure things mostly work so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on PR #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461#issuecomment-4608563185
Now that #463 is merged, bumping this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461#discussion_r3270368123
##########
package.json:
##########
@@ -31,7 +30,9 @@
"mocha-jenkins-reporter": "~0.4.8",
"proxyquire": "~2.1.3",
"sinon": "~15.2.0",
- "temp": ">= 0.8.3"
+ "temp": ">= 0.8.3",
+ "ts-mocha": "^10.0.0",
+ "typescript": "^5.7.3"
Review Comment:
The `test`, `unit`, `integration_short`, `integration_long`, `ci_jenkins`, `ci_appveyor`, `ci_unit_appveyor`, and `server_api` scripts all still invoke plain `mocha`, but the test files have been renamed to `.ts`. As a result, none of these npm scripts will pick up tests anymore (mocha by default only loads `.js`). Consider switching these scripts to `ts-mocha` (which was just added as a devDependency) or adding a mocha `--extension ts` / `require ts-node/register` configuration. The PR description suggests running `npx ts-mocha` manually, but leaving the scripts broken will likely also break CI invocations referencing them.
##########
package.json:
##########
@@ -18,7 +18,6 @@
"graphdb"
],
"license": "Apache-2.0",
Review Comment:
Removing the `"types": "./index.d.ts"` field is a breaking change for any TypeScript consumer of this package. After this PR, downstream TypeScript projects importing `cassandra-driver` will no longer get type definitions (since `index.d.ts` is no longer shipped, and there's no replacement declared here). Even though `tsconfig.json` enables `declaration: true` with `outDir: "out"`, nothing in `package.json` points to the generated `.d.ts` files, and `"main"` is not defined at all. Consider keeping `types` pointing at a valid declaration entry point (e.g., the generated `out/index.d.ts`) and also setting `"main"`/`"files"` so the published package still exposes types and a working entry point during the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461#discussion_r3270382705
##########
package.json:
##########
@@ -18,7 +18,6 @@
"graphdb"
],
"license": "Apache-2.0",
Review Comment:
Correct, but we will fix those later, because we will add roll-up and api-extractor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461#discussion_r3270376570
##########
package.json:
##########
@@ -31,7 +30,9 @@
"mocha-jenkins-reporter": "~0.4.8",
"proxyquire": "~2.1.3",
"sinon": "~15.2.0",
- "temp": ">= 0.8.3"
+ "temp": ">= 0.8.3",
+ "ts-mocha": "^10.0.0",
+ "typescript": "^5.7.3"
Review Comment:
Correct, we will need to fix those scripts and other project setup later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on PR #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461#issuecomment-4493137907
GH does not allow me to request @toptobes 's review, but I'd appreciate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSNODEJS-8: First TypeScript PR: Massive rename [cassandra-nodejs-driver]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding merged PR #461:
URL: https://github.com/apache/cassandra-nodejs-driver/pull/461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org