You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/03/25 05:23:40 UTC
[PR] [SPARK-56192] Exclude `spotbugs-annotations` from the uber jar [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #581:
URL: https://github.com/apache/spark-kubernetes-operator/pull/581
### What changes were proposed in this pull request?
This PR changes `spotbugs-annotations` from `implementation` to `compileOnly` in `spark-operator/build.gradle` and adds it as `testImplementation` for test compilation.
```diff
$ ls -al spark-operator/build/libs/spark-kubernetes-operator-0.9.0-SNAPSHOT-all.jar
- -rw-r--r--@ 1 dongjoon staff 140340193 Mar 23 11:52 spark-operator/build/libs/spark-kubernetes-operator-0.9.0-SNAPSHOT-all.jar
+ -rw-r--r--@ 1 dongjoon staff 140326750 Mar 24 22:18 spark-operator/build/libs/spark-kubernetes-operator-0.9.0-SNAPSHOT-all.jar
```
### Why are the changes needed?
`spotbugs-annotations` is a static analysis annotation library (e.g., `@SuppressFBWarnings`) that is only needed at compile time and has no runtime purpose. Keeping it as `implementation` causes it to be bundled into the uber JAR unnecessarily, increasing the final JAR size. Changing it to `compileOnly` excludes it from the shadow JAR output.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.6 1M)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56192] Exclude `spotbugs-annotations` from the uber jar [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #581:
URL: https://github.com/apache/spark-kubernetes-operator/pull/581#issuecomment-4123981002
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56192] Exclude `spotbugs-annotations` from the uber jar [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #581: [SPARK-56192] Exclude `spotbugs-annotations` from the uber jar
URL: https://github.com/apache/spark-kubernetes-operator/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56192] Exclude `spotbugs-annotations` from the uber jar [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #581:
URL: https://github.com/apache/spark-kubernetes-operator/pull/581#issuecomment-4123977951
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org